Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#990 closed enhancement (fixed)

DHCPv6 server as a dummy BIND 10 component

Reported by: shane Owned by: tomek
Priority: medium Milestone: Sprint-DHCP-20110628
Component: Unclassified Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0.0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

Set up a DHCPv6 server as a dummy BIND 10 component

Subtickets

Change History (11)

comment:1 Changed 9 years ago by shane

Probably best to look at src/bin/auth/main.cc as a starting point.

comment:2 Changed 9 years ago by tomek

  • Owner set to tomek
  • Status changed from new to accepted

comment:3 Changed 9 years ago by tomek

  • Owner changed from tomek to UnAssigned
  • Status changed from accepted to reviewing

Implemented b10-dhcp6 as a dummy component. It doesn't do anything useful now, just sits there and says that it is alive every 10 seconds.

There are 3 tests implemented:

  • bind10/tests/TestBob::test_init (actually extended existing test)
  • bind10/tests/TestStartStopProcessesBob::test_start_dhcp
  • dhcp6/tests/TestDhcpv6Daemon::test_alive

This is my first set of changes to bind10, so I appreciate any comments and suggestions.

comment:4 Changed 9 years ago by jelte

  • Owner changed from UnAssigned to jelte

comment:5 follow-up: Changed 9 years ago by jelte

  • Owner changed from jelte to tomek

Yay, a running module :)

A few general comments:

make distcheck fails; the manpage file is not in EXTRA_DIST (that line is commented out, it should also contain dhcp6.spec)

Another build/run issue is that the call to dhcp6_test.py in src/bin/dhcp6/tests/Makefile.am should use $(abs_srcdir) instead of $(abs_builddir); dhcp6_test.py is not generated and hence lives in the source tree, not the build tree. In most cases these trees are the same but that is not the case if you use a separate build directory.

Boss has internal values to know when to start dhcp(6), but this is not reflected in the spec and the config parsing yet (though i feel compelled to note that i think we handle configuration in bin/bind10 of what to start badly right now anyway)

The run_bind10.sh(.in) script does not include the bin/dhcp6 path, making it fail if I try to run it from source tree.

main.cc:

Just some tiny remarks for now:

The name for AUTH_SPECFILE_LOCATION seems a bit off :)

There's tabs at the beginning of lines 117 and 118

comment:6 in reply to: ↑ 5 Changed 9 years ago by tomek

Replying to jelte:

make distcheck fails; the manpage file is not in EXTRA_DIST (that line is commented out, it should also contain dhcp6.spec)

Done.

Another build/run issue is that the call to dhcp6_test.py in src/bin/dhcp6/tests/Makefile.am should use $(abs_srcdir) instead of $(abs_builddir);

Done.

Boss has internal values to know when to start dhcp(6), but this is not reflected in the spec and the config parsing yet (though i feel compelled to note that i think we handle configuration in bin/bind10 of what to start badly right now anyway)

As dhcp6 does not offer *any* functionality, we don't want to expose its existence at this time. There is ticket #1058 for enabling configuration and updating the spec. This will be done after there's minimal functionality that can be exposed (echo server).

The run_bind10.sh(.in) script does not include the bin/dhcp6 path, making it fail if I try to run it from source tree.

It does now.

main.cc:
The name for AUTH_SPECFILE_LOCATION seems a bit off :)

Indeed it was. Not anymore.

There's tabs at the beginning of lines 117 and 118

Removed.

Thanks for thorough review.

comment:7 Changed 9 years ago by tomek

  • Owner changed from tomek to jelte

comment:8 Changed 9 years ago by jelte

  • Owner changed from jelte to tomek

Ok, looks good. Since this isn't actually exposed yet, I assume we don't want a changelog entry? In that case it can be merged.

comment:9 Changed 9 years ago by tomek

  • Resolution set to fixed
  • Status changed from reviewing to closed

Merged into master (4a590df96a1b1d373e87f1f56edaceccb95f267d).
Note: there's no CHANGELOG update, as DHCP6 is not yet useful, so we don't want to have it exposed yet.

comment:10 Changed 9 years ago by shane

  • Milestone changed from Sprint-DHCP-20110628 to Sprint-DHCP-20110712

Milestone Sprint-DHCP-20110628 deleted

comment:11 Changed 9 years ago by shane

  • Milestone changed from Sprint-DHCP-20110712 to Sprint-DHCP-20110628
Note: See TracTickets for help on using tickets.