Opened 9 years ago

Closed 9 years ago

#946 closed defect (fixed)

xfrin fails to do retransfer with TSIG

Reported by: jinmei Owned by: jinmei
Priority: medium Milestone: Sprint-20110531
Component: xfrin Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: High
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 2.0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description


Subtickets

Change History (5)

comment:1 Changed 9 years ago by jinmei

Branch trac946 is ready for review.

The first commit is not directly relevant to fix the bug, but will help
when the bug actually occurred (and it's generally advisable to catch
possible C++ exceptions gracefully anyway).

The main fix is in xfrin.py.in, which should be mostly trivial.

See the new test test_do_soacheck_and_xfrin_with_tsig for what was
wrong and what is actually expected.

Other tests were also modified due to the change of how xfrin manages
tsig contexts internally. They are a bit complicated due to the
introduction of a lambda expression (as a hook for faked context),
but their behavior was essentially the same.

I don't plan to add a changelog entry for this because this bug has
been in master for a very short period and in mostly invisible to
public.

comment:2 Changed 9 years ago by jinmei

  • Owner changed from jinmei to UnAssigned
  • Status changed from new to reviewing

comment:3 follow-up: Changed 9 years ago by vorner

  • Owner changed from UnAssigned to jinmei

I did have a look and didn't find any problems. I just hope I didn't overlook anything, as I'm quite tired now (but I read the code first, the description after it and it matched what I got from the code). So I think the code is OK.

comment:4 in reply to: ↑ 3 Changed 9 years ago by jinmei

Replying to vorner:

I did have a look and didn't find any problems. I just hope I didn't overlook anything, as I'm quite tired now (but I read the code first, the description after it and it matched what I got from the code). So I think the code is OK.

Thanks for the prompt review!

Merge done, closing ticket. I'll give a task estimate of 2 for this
ticket.

comment:5 Changed 9 years ago by jinmei

  • Estimated Difficulty changed from 0.0 to 2.0
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.