Opened 9 years ago

Closed 9 years ago

#907 closed defect (invalid)

variable argument list and pointer reference

Reported by: fdupont Owned by:
Priority: low Milestone:
Component: Unclassified Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: Low
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 0.0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

I've found a funny problem with log methods: they are declared with a variable argument list following a reference to a MessageID, a char * typedef.
On Windows stdarg.h is implemented with macros which are confused so the run time init test (aka logger_support_test.cc) doesn't pass.
The fix is pretty easy: don't use reference (i.e., remove the &). BTW IMHO taking the reference of a pointer is not the best idea...

Subtickets

Change History (1)

comment:1 Changed 9 years ago by shane

  • Milestone New Tasks deleted
  • Resolution set to invalid
  • Status changed from new to closed

Stephen reports: This issue no longer applies, as the current API no longer uses variable argument lists.

Resolving ticket.

Note: See TracTickets for help on using tickets.