Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#872 closed defect (complete)

review jreed-host

Reported by: jreed Owned by: jreed
Priority: medium Milestone: Sprint-20110517
Component: Unclassified Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 1.0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

I have various small updates to src/bin/host in the jreed-host branch.

I guess these could be reviewed before #856.

It does not have tests.

This should show the changes:

git diff fb4a0a36ba0d90409684e8042916341ce35c5f21 21385dbdb72fe02275c859a88674a9d2166a0ed0

The log will show the log.

Subtickets

Change History (8)

comment:1 Changed 9 years ago by zzchen_pku

  • Owner set to zzchen_pku
  • Status changed from new to reviewing

I'll review it before working on #856.

Last edited 9 years ago by zzchen_pku (previous) (diff)

comment:2 follow-up: Changed 9 years ago by zzchen_pku

  • Owner changed from zzchen_pku to jreed

The code looks okay.
But I found the README file hasn't been updated accordingly.
And there is a make error:

make[1]: *** No rule to make target `b10-host.1', needed by `all-am'.  Stop.

Anyway, I think we should add unit-tests for src/bin/host.cc.

Last edited 9 years ago by zzchen_pku (previous) (diff)

comment:3 in reply to: ↑ 2 Changed 9 years ago by jreed

Replying to zzchen_pku:

The code looks okay.
But I found the README file hasn't been updated accordingly.

I will move the docs into the manual page itself.

And there is a make error:

make[1]: *** No rule to make target `b10-host.1', needed by `all-am'.  Stop.

I forgot to add the manual page to git tree.

Anyway, I think we should add unit-tests for src/bin/host.cc.

A new ticket was created for this: #874.

comment:4 Changed 9 years ago by jreed

I am also renaming installed executable to b10-host (as I mentioned one year ago).

comment:5 Changed 9 years ago by zzchen_pku

Okay, in this case, I think the branch can be merged now.

comment:6 Changed 9 years ago by jreed

  • Resolution set to complete
  • Status changed from reviewing to closed

Closing this now. I merged to master.

Note I renamed host to b10-host and I also included a manual page (which has not been reviewed yet).

comment:7 follow-up: Changed 9 years ago by shane

  • Milestone changed from New Tasks to Sprint-20110517

Looks like this work was done in the current sprint. I'm moving it to that.

Jerry, maybe you can provide an estimate of how much effort it was?

comment:8 in reply to: ↑ 7 Changed 9 years ago by zzchen_pku

  • Estimated Difficulty changed from 0.0 to 1.0

Replying to shane:

Looks like this work was done in the current sprint. I'm moving it to that.

Jerry, maybe you can provide an estimate of how much effort it was?

Ok, done.

Note: See TracTickets for help on using tickets.