Opened 9 years ago

Closed 9 years ago

#868 closed defect (fixed)

regression fix: run_bind10.sh doesn't work

Reported by: jinmei Owned by: jinmei
Priority: very high Milestone: Sprint-20110503
Component: build system Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: High
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 1.0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

There are several problems.

  • typo in cfgmgr
  • missing path to new libraries (mainly due to the introduction of libutil)
  • incorrect path to spec files in b10-stats and its friends

Attached patch fixes all of these. Mostly trivial, but it's not super so,
so it would be good if we can make a sanity check on it.

Could someone review it?

Subtickets

Attachments (1)

run.diff (3.3 KB) - added by jinmei 9 years ago.

Download all attachments as: .zip

Change History (11)

Changed 9 years ago by jinmei

comment:1 Changed 9 years ago by jinmei

  • Estimated Difficulty changed from 0.0 to 1.0
  • Milestone changed from New Tasks to Sprint-20110503

comment:2 Changed 9 years ago by jinmei

As requested I've put it to the current sprint. I've also given it my personal estimate.

comment:3 Changed 9 years ago by jinmei

  • Owner changed from jreed to UnAssigned
  • Status changed from new to reviewing

comment:4 Changed 9 years ago by vorner

  • Owner changed from UnAssigned to vorner

comment:5 follow-up: Changed 9 years ago by vorner

  • Owner changed from vorner to jinmei

Hello

The tests in stats fail (almost all of them) with something like this:

----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/vorner/work/bind10/src/bin/stats/tests/isc/config/ccsession.py", line 58, in module_spec_from_file
    file = open(spec_file)
IOError: [Errno 2] No such file or directory: '/home/vorner/work/bind10/src/bin/stats/src/bin/stats/stats.spec'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/vorner/work/bind10/src/bin/stats/tests/b10-stats_test.py", line 517, in setUp
    self.listener = CCSessionListener(self.subject, verbose=True)
  File "/home/vorner/work/bind10/src/bin/stats/stats.py", line 182, in __init__
    self.session)
  File "/home/vorner/work/bind10/src/bin/stats/tests/isc/config/ccsession.py", line 119, in __init__
    module_spec = module_spec_from_file(spec_file_name)
  File "/home/vorner/work/bind10/src/bin/stats/tests/isc/config/ccsession.py", line 64, in module_spec_from_file
    raise ModuleSpecError("JSON read error: " + str(ioe))
isc.config.ccsession.ModuleSpecError: JSON read error: [Errno 2] No such file or directory: '/home/vorner/work/bind10/src/bin/stats/src/bin/stats/stats.spec'

It seems the test itself might be wrong as well. Would you have a look?

Thanks

comment:6 in reply to: ↑ 5 Changed 9 years ago by jinmei

Replying to vorner:

The tests in stats fail (almost all of them) with something like this:

Oops...good catch. I was naive and didn't know the stats module relied
on B10_FROM_SOURCE in their tests.

Now I created a separate branch (trac868) and committed the original patch
and an additional set of changes that fix the test failure.

I also "fixed" run_b10-stats and run_b10-stats-httpd, but I was not
really sure if these script can be usable in the first place, and so
I was not sure if the original patch broke these run scripts, much
less whether my change "fixes" it. The stats things need the config
manager running, but there's no run_xxx trick for it, so, unless we
start everything via the boss using run_bind10.sh (in which case we
wouldn't use run_b10-stats{,httpd} anyway), the stats daemons won't
be able to run from the source. I suspect we should actually remove
these run-xxx scripts, but that's a separate issue (which I plan to
raise separately).

Please check if this version of patch is okay.

Thanks,

comment:7 Changed 9 years ago by jinmei

  • Owner changed from jinmei to vorner

comment:8 follow-up: Changed 9 years ago by vorner

  • Owner changed from vorner to jinmei

Yes, this one works. Please merge.

comment:9 in reply to: ↑ 8 Changed 9 years ago by jinmei

Replying to vorner:

Yes, this one works. Please merge.

Thanks, merged, closing ticket.

comment:10 Changed 9 years ago by jinmei

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.