Opened 9 years ago

Closed 9 years ago

#848 closed defect (fixed)

Missing name when using errno in notify_out.py

Reported by: shane Owned by: shane
Priority: low Milestone: Sprint-20110517
Component: xfrin Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: Medium
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 1.0 Add Hours to Ticket: 0
Total Hours: 1.0 Internal?: no

Description

Jeremy reported the following:

Traceback (most recent call last):
  File "/usr/pkg/lib/python3.1/threading.py", line 509, in 
_bootstrap_inner
    self.run()
  File "/usr/pkg/lib/python3.1/threading.py", line 462, in run
    self._target(*self._args, **self._kwargs)
  File 
"/home/reed/opt/bind10/lib/python3.1/site-packages/isc/notify/notify_out.py", 
line 157, in _dispatcher
    replied_zones, not_replied_zones = self._wait_for_notify_reply()
  File 
"/home/reed/opt/bind10/lib/python3.1/site-packages/isc/notify/notify_out.py", 
line 303, in _wait_for_notify_reply
    if err.args[0] != EINTR:
NameError: global name 'EINTR' is not defined

It turns out this is an error. It should be using errno.EINTR, as the import of errno is done like:

import errno

And not like:

from errno import *

It's a one-line fix.

Subtickets

Change History (7)

comment:1 Changed 50 years ago by shane

  • Add Hours to Ticket changed from 0.0 to 1.0
  • Total Hours changed from 0.0 to 1.0

comment:1 Changed 9 years ago by stephen

  • Milestone changed from Year 3 Task Backlog to New Tasks

comment:2 Changed 9 years ago by shane

  • Component changed from Unclassified to xfrin
  • Defect Severity set to Medium
  • Estimated Difficulty changed from 0.0 to 1
  • Priority changed from major to minor
  • Sub-Project set to DNS

comment:3 Changed 9 years ago by shane

  • Milestone changed from New Tasks to Sprint-20110517
  • Owner set to UnAssigned
  • Status changed from new to reviewing

This was such a small fix, I went ahead and did it and added it to this sprint.

comment:4 Changed 9 years ago by stephen

  • Owner changed from UnAssigned to stephen

comment:5 Changed 9 years ago by stephen

  • Owner changed from stephen to shane

All seems OK, please merge.

comment:6 Changed 9 years ago by shane

  • Add Hours to Ticket changed from 0 to 1
  • Resolution set to fixed
  • Status changed from reviewing to closed

Okay, merged.

Note: See TracTickets for help on using tickets.