Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#800 closed enhancement (complete)

Change Boss to start socket creator

Reported by: stephen Owned by: vorner
Priority: medium Milestone: Sprint-20110802
Component: ~Boss of BIND (obsolete) Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 5 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description


Subtickets

Change History (10)

comment:1 Changed 9 years ago by vorner

Just one note, the vorner-sockcreator branch has tests for this in its last two or three commits, they might be useful. The tests will not be merged with #366 (because it fails, the functionality is not yet implemented). Or, for part of it, at last ‒ the communacion protocol with the socket creator.

comment:2 Changed 9 years ago by jelte

  • Defect Severity set to N/A
  • Sub-Project set to DNS

When we do this, we need to remove or change the log message BIND10_START_AS_NON_ROOT in src/bin/bind10

comment:3 Changed 9 years ago by stephen

  • Milestone changed from Year 3 Task Backlog to Sprint-20110802

comment:4 Changed 9 years ago by vorner

To make sure this is clear, the socket creator must be special in how it is started, it needs its STDIO redirected to a unix domain socket. It probably should be part of this ticket.

comment:5 Changed 8 years ago by vorner

  • Owner set to vorner
  • Status changed from new to accepted

comment:6 Changed 8 years ago by vorner

  • Owner changed from vorner to UnAssigned
  • Status changed from accepted to reviewing

Hello.

The socket creator is started (differently than the rest, because it needs the stdio redirection and can't be restarted) and a code to talk to it is in place. It is tested (with small exception of actually starting it, but I tried it manually and it starts and when I kill it, boss nicely shuts down), but as there's nothing that could request the sockets, it is not tried.

I don't think this needs a changelog entry, it will get one once boss can actually provide the sockets.

comment:7 Changed 8 years ago by jelte

  • Owner changed from UnAssigned to jelte

comment:8 Changed 8 years ago by jelte

  • Owner changed from jelte to vorner

I've taken the liberty to fix a few typos and added a few words to some of the docstrings in sockcreator.py, please verify.

No comments on sockcreator.py code.

Small nit about the additions to the .mes file; I tend to use search in my editor to find a string, but it has been the general convention to order the messages alphabetically by their identifier.

bind10_src.py.in:

self.sockcreator = bind10.sockcreator.Creator("@@LIBEXECDIR@@:" +

os.environPATH?)

IMO we should move away from configure-time replacements here and move them to bind10_config.py.in (first of all to get rid of generated python files as much as possible, but also for potential flexibility in setup), but since this is not the only occurrence i think we can make such a move a separate ticket.

If you want to, please reorder the messages, and I think this can be merged.

comment:9 Changed 8 years ago by vorner

  • Resolution set to complete
  • Status changed from reviewing to closed

OK, sorted and merged.

comment:10 Changed 8 years ago by stephen

  • Estimated Difficulty changed from 0.0 to 5
Note: See TracTickets for help on using tickets.