Opened 9 years ago

Closed 9 years ago

#743 closed enhancement (complete)

Conversion of config library to use the new logging interface

Reported by: stephen Owned by: jelte
Priority: low Milestone: Sprint-20110517
Component: configuration Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket: logging
Estimated Difficulty: 5.0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

Similar to ticket #738, but applied to the configuration library.

Subtickets

Change History (7)

comment:1 Changed 9 years ago by shane

  • Estimated Difficulty changed from 0.0 to 5
  • Milestone changed from Year 3 Task Backlog to Sprint-20110419
  • Priority changed from major to minor

comment:2 Changed 9 years ago by shane

  • Defect Severity set to N/A
  • Feature Depending on Ticket set to logging
  • Sub-Project set to DNS

comment:3 Changed 9 years ago by jelte

  • Owner set to jelte
  • Status changed from new to assigned

comment:4 Changed 9 years ago by jelte

  • Owner changed from jelte to UnAssigned
  • Status changed from assigned to reviewing

Ready for review.

While creating messages and extended descriptions, I noticed a few potential issues which i fixed along the way:

  • If the config manager does not accept the modules specification, or if the 'get current config' command returns with an error, the system used to ignore that fact apart from printing an error, and continue running. It seems much better to explicitely fail, since the module would be running independent of what its config is supposed to be, which would be really unstable
  • If the module cannot parse a command it gets over the command channel, it used to send back an error. If we have multiple modules listening on the same channel, this would result in multiple errors being returned It will now log an error, but it will not send back an answer

should this need a changelog:
[func] C++ client side of configuration now uses BIND10 logging system. It also has improved error handling when communicating with the rest of the system.

comment:5 Changed 9 years ago by stephen

  • Owner changed from UnAssigned to stephen

comment:6 Changed 9 years ago by stephen

  • Owner changed from stephen to jelte

Reviewed commit f5278f2ac4becb33b93dc4c2fa7e6558a7daad8f

src/lib/config/config_log.h
Should get rid of unused debug-level definitions (which are not relevant to this module).

Comment is wrong - isc::config::config_logger is the CONFIG logger.

src/lib/config/configdef.mes
Suggest that the message text start with a lower-case character (unless something that should be in capital letters such as the type of a resource record). The reason is that (the current) message formatting is

MESSAGE_ID, message text

...and a lower-case letter after the comma follows the rules of English. (Does not apply to the JSON_PARSE error, where the first word is JSON which should be in upper-case.)

ChangeLog entry is fine.

Another review is not useful, please merge when you've made the changes.

comment:7 Changed 9 years ago by jelte

  • Resolution set to complete
  • Status changed from reviewing to closed

Thanks, merged, closing ticket.

Note: See TracTickets for help on using tickets.