Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#699 closed defect (fixed)

missing glue a record when request RR type is ANY

Reported by: zhangcuiling Owned by: zzchen_pku
Priority: medium Milestone: Sprint-20110405
Component: Unclassified Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: 2.0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

git version no. 0a9ce967a515894bd7c46cf86a6ff4bc3d856b3a

zone name is example.com

missing glue A RR for NS RR

$ dig @localhost example.com ANY -p 30002

; <<>> DiG 9.7.2-P2 <<>> @localhost example.com ANY -p 30002
; (1 server found)
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 45308
;; flags: qr aa rd; QUERY: 1, ANSWER: 4, AUTHORITY: 0, ADDITIONAL: 0
;; WARNING: recursion requested but not available

;; QUESTION SECTION:
;example.com.                   IN      ANY

;; ANSWER SECTION:
example.com.            86400   IN      NS      NS1.example.com.
example.com.            86400   IN      NS      NS2.demo.example.com.
example.com.            86400   IN      NS      NS3.noexist.cn.
example.com.            86400   IN      SOA     NS1.example.com. root.example.com. 2010091701 3600 900 604800 3600

;; Query time: 0 msec
;; SERVER: 127.0.0.1#30002(127.0.0.1)
;; WHEN: Thu Mar 17 13:54:38 2011
;; MSG SIZE  rcvd: 139

$ dig @localhost example.com NS -p 30002

; <<>> DiG 9.7.2-P2 <<>> @localhost example.com NS -p 30002
; (1 server found)
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 64531
;; flags: qr aa rd; QUERY: 1, ANSWER: 3, AUTHORITY: 0, ADDITIONAL: 2
;; WARNING: recursion requested but not available

;; QUESTION SECTION:
;example.com.                   IN      NS

;; ANSWER SECTION:
example.com.            86400   IN      NS      NS1.example.com.
example.com.            86400   IN      NS      NS2.demo.example.com.
example.com.            86400   IN      NS      NS3.noexist.cn.

;; ADDITIONAL SECTION:
NS1.example.com.        86400   IN      A       218.241.111.236
NS2.demo.example.com.   86400   IN      A       218.241.108.15

;; Query time: 0 msec
;; SERVER: 127.0.0.1#30002(127.0.0.1)
;; WHEN: Thu Mar 17 13:54:47 2011
;; MSG SIZE  rcvd: 130

missing glue A RR for MX RR

$ dig @localhost example.com a.example.com ANY -p 30002

; <<>> DiG 9.7.2-P2 <<>> @localhost example.com a.example.com ANY -p 30002
; (1 server found)
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 34595
;; flags: qr aa rd; QUERY: 1, ANSWER: 5, AUTHORITY: 3, ADDITIONAL: 2
;; WARNING: recursion requested but not available

;; QUESTION SECTION:
;a.example.com.                 IN      ANY

;; ANSWER SECTION:
a.example.com.          86400   IN      A       192.168.1.10
a.example.com.          86400   IN      PTR     1.1.226.159.cnnic.cn.
a.example.com.          86400   IN      MX      10 mail.example.com.
a.example.com.          86400   IN      AAAA    2001:dc7::1
a.example.com.          86400   IN      DNAME   sub1.cnnic.cn.

;; AUTHORITY SECTION:
example.com.            86400   IN      NS      NS1.example.com.
example.com.            86400   IN      NS      NS2.demo.example.com.
example.com.            86400   IN      NS      NS3.noexist.cn.

;; ADDITIONAL SECTION:
NS1.example.com.        86400   IN      A       218.241.111.236
NS2.demo.example.com.   86400   IN      A       218.241.108.15

;; Query time: 10 msec
;; SERVER: 127.0.0.1#30002(127.0.0.1)
;; WHEN: Thu Mar 17 13:55:28 2011
;; MSG SIZE  rcvd: 248

$ dig @localhost a.example.com MX -p 30002

; <<>> DiG 9.7.2-P2 <<>> @localhost a.example.com MX -p 30002
; (1 server found)
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 15957
;; flags: qr aa rd; QUERY: 1, ANSWER: 1, AUTHORITY: 3, ADDITIONAL: 3
;; WARNING: recursion requested but not available

;; QUESTION SECTION:
;a.example.com.                 IN      MX

;; ANSWER SECTION:
a.example.com.          86400   IN      MX      10 mail.example.com.

;; AUTHORITY SECTION:
example.com.            86400   IN      NS      NS1.example.com.
example.com.            86400   IN      NS      NS2.demo.example.com.
example.com.            86400   IN      NS      NS3.noexist.cn.

;; ADDITIONAL SECTION:
mail.example.com.       86400   IN      A       10.4.0.1
NS1.example.com.        86400   IN      A       218.241.111.236
NS2.demo.example.com.   86400   IN      A       218.241.108.15

;; Query time: 0 msec
;; SERVER: 127.0.0.1#30002(127.0.0.1)
;; WHEN: Thu Mar 17 13:55:43 2011
;; MSG SIZE  rcvd: 169

Subtickets

Change History (12)

comment:1 Changed 9 years ago by zzchen_pku

PS: The test is based on in-memory datasource.

comment:2 Changed 9 years ago by zzchen_pku

  • Owner set to zzchen_pku
  • Status changed from new to assigned

comment:3 Changed 9 years ago by zzchen_pku

  • Owner changed from zzchen_pku to UnAssigned
  • Status changed from assigned to reviewing

trac699 is ready for review.
Changes pushed as commit 681b1839bca185f19eca8e0fe567bb0012743a79.

comment:4 Changed 9 years ago by jinmei

  • Milestone set to A-Team-Task-Backlog

comment:5 Changed 9 years ago by stephen

  • Milestone A-Team-Task-Backlog deleted

Milestone A-Team-Task-Backlog deleted

comment:6 Changed 9 years ago by shane

  • Milestone set to Sprint-20110405

comment:7 Changed 9 years ago by vorner

  • Owner changed from UnAssigned to vorner

comment:8 follow-up: Changed 9 years ago by vorner

Hello

The code is nice and clean. However, I believe it should have a changelog entry. Would you propose one?

Thanks

comment:9 Changed 9 years ago by vorner

  • Owner changed from vorner to zzchen_pku

comment:10 in reply to: ↑ 8 Changed 9 years ago by zzchen_pku

Replying to vorner:

The code is nice and clean. However, I believe it should have a changelog entry. Would you propose one?

I think so.
Proposed ChangeLog? entry:

210.  [bug]       jerry
  src/bin/auth: fixed a bug where type ANY queries don't provide
  additional glue records for ANSWER section.
  (Trac #699, git 510924ebc57def8085cc0e5413deda990b2abeee)

comment:11 Changed 9 years ago by zzchen_pku

  • Resolution set to fixed
  • Status changed from reviewing to closed

Merged, closing it.
Thanks for your review:)

comment:12 Changed 9 years ago by zzchen_pku

  • Estimated Difficulty changed from 0.0 to 2.0
Note: See TracTickets for help on using tickets.