Opened 10 years ago

Closed 9 years ago

#68 closed enhancement (complete)

Install include headers

Reported by: jreed Owned by: jreed
Priority: medium Milestone: 04. 2nd Incremental Release: Early Adopters
Component: libdns++ Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: Add Hours to Ticket:
Total Hours: Internal?:

Description

Since we install libraries we should also install the related include headers too.

Subtickets

Attachments (1)

68.diff (914 bytes) - added by jreed 9 years ago.
patch to install include headers

Download all attachments as: .zip

Change History (6)

Changed 9 years ago by jreed

patch to install include headers

comment:1 follow-up: Changed 9 years ago by jreed

I added a patch for this to this ticket. But libdns provides many other header files. What header files should be installed for public development work?

comment:2 Changed 9 years ago by shane

  • Component changed from Unclassified to DNSPacket API
  • Milestone set to 04. 2nd Incremental Release
  • Owner set to jinmei
  • Status changed from new to assigned
  • Type changed from defect to enhancement

Assigning to Jinmei who can hopefully answer this question.

comment:3 in reply to: ↑ 1 Changed 9 years ago by jinmei

Replying to jreed:

I added a patch for this to this ticket. But libdns provides many other header files. What header files should be installed for public development work?

I believe all *.h under lib/dns are necessary except *-placeholder.h. No *.h in subdistories are necessary (most notably *.h's under rdata/ are not necessary).

To be precise, we could probably eliminate some others such as tsig.h (currently not used), {base32,base64,hex,sha1}.h (used only internally, and not actually DNS specific). But it would be safer to include them at the moment, assuming it's still a pre alpha stage and we can change the set of install files later without worry about compatibility problems.

comment:4 Changed 9 years ago by jinmei

  • Owner changed from jinmei to jreed

comment:5 Changed 9 years ago by jreed

  • Resolution set to complete
  • Status changed from assigned to closed

I committed the changes to r1941. I forgot to say it may not have been reviewed but is very minor change.

Note: See TracTickets for help on using tickets.