Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#671 closed defect (fixed)

error in config_data_test.py results

Reported by: jreed Owned by: jelte
Priority: low Milestone: Sprint-20110419
Component: configuration Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: 1.0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

make check in src/lib/python/isc/config/ results in:

Error: identifier 'Spec24/item' not found

(tests/config_data_test.py)

In jabber, I was told: the error itself is expected, we might want to replace the printing of said error with something better or simply remove it.

Subtickets

Change History (8)

comment:1 Changed 9 years ago by jelte

  • Owner changed from jelte to UnAssigned
  • Status changed from new to reviewing

commit d27da40718b797aca37ad5bab7215592a089627a

replaced the print("Error: ") with a raise DataNotFoundError? (and updated the test to expect said raise instead of an empty result)

comment:2 Changed 9 years ago by shane

  • Milestone set to Sprint-20110405

comment:3 Changed 9 years ago by zzchen_pku

  • Owner changed from UnAssigned to zzchen_pku

comment:4 Changed 9 years ago by zzchen_pku

  • Owner changed from zzchen_pku to jelte

It looks ok.
But I still find

[['ConfigManager', None, {'command': ['get_config', {'module_name': 'Spec2'}]}]]
[Spec2] Error requesting configuration: just an error

while making check in src/lib/python/isc/config/, which is a little confusing, it might be nice to send the output to someplace else when running the tests.

comment:5 follow-up: Changed 9 years ago by jelte

  • Owner changed from jelte to zzchen_pku

Hmm, I noticed there are also other 'TODO: log error' comments in there, since this was the only one that was actually printed, and we do need to fix those, but right now It's a bit unclear to me if and how we decided to do logging in python, I've commented out that line and made a TODO of that as well.

Also removed an unnecessary print in the test itself, output should now be clean.

comment:6 in reply to: ↑ 5 Changed 9 years ago by zzchen_pku

  • Owner changed from zzchen_pku to jelte

Replying to jelte:

Hmm, I noticed there are also other 'TODO: log error' comments in there, since this was the only one that was actually printed, and we do need to fix those, but right now It's a bit unclear to me if and how we decided to do logging in python, I've commented out that line and made a TODO of that as well.
Also removed an unnecessary print in the test itself, output should now be clean.

It looks OK to me, please feel free to merge.

comment:7 Changed 9 years ago by jelte

  • Resolution set to fixed
  • Status changed from reviewing to closed

Thanks! Merged, closing ticket.

comment:8 Changed 9 years ago by jelte

  • Estimated Difficulty changed from 0.0 to 1
Note: See TracTickets for help on using tickets.