Opened 9 years ago

Closed 9 years ago

#639 closed defect (fixed)

remove empty code in lib/cache

Reported by: jinmei Owned by: zhanglikun
Priority: low Milestone: Sprint-20110614
Component: resolver Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 1.0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

See https://lists.isc.org/pipermail/bind10-dev/2011-February/002037.html
for the background issue.

The proposed action has been agreed at the biweekly call on Mar 1.

Specific task actions are:

  • remove MessageCache?/RRsetCache/ResolverCache::dump/load/resize
  • add comments about future possibility of these features
  • remove the corresponding suppression rule in src/cppcheck-suppress.lst

This is mostly a trivial task, but I'm creating a ticket explicitly
as I proposed in the call. This is a minor cleanup but I'd like to
do it before the end of y2.

Subtickets

Change History (12)

comment:1 Changed 9 years ago by stephen

  • Milestone A-Team-Task-Backlog deleted

Milestone A-Team-Task-Backlog deleted

comment:2 Changed 9 years ago by jinmei

  • Defect Severity set to N/A
  • Milestone set to Next-Sprint-Proposed
  • Sub-Project set to DNS

comment:3 Changed 9 years ago by stephen

  • Milestone changed from Next-Sprint-Proposed to Sprint-20110614

comment:4 Changed 9 years ago by zhanglikun

  • Owner set to zhanglikun
  • Status changed from new to assigned

comment:5 Changed 9 years ago by zhanglikun

  • Owner changed from zhanglikun to jinmei
  • Status changed from assigned to reviewing

The code(Trac639) is ready for view, I think jinmei should be the best person to review it. So assign it to you, jinmei :)

comment:6 Changed 9 years ago by jinmei

It doesn't compile for my usual environment (MacOS X + clang++).

/bin/sh ../../../libtool --tag=CXX   --mode=compile clang++ -DHAVE_CONFIG_H -I. -I../../..  -I../../../src/lib -I../../../src/lib -I/opt/local/include -pthread -I../../../src/lib/util -I../../../src/lib/util -I../../../src/lib/dns -I../../../src/lib/dns -I../../../src/lib/nsas -I../../../src/lib/nsas -I../../../src/lib/cache -I../../../src/lib/cache -I/opt/local/include   -I../../../ext/asio -I../../../ext/coroutine -DASIO_DISABLE_THREADS=1 -Wall -Wextra -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -Werror -fPIC -Wno-missing-field-initializers -Wno-unused-parameter -g -O2 -MT resolver_cache.lo -MD -MP -MF .deps/resolver_cache.Tpo -c -o resolver_cache.lo resolver_cache.cc
libtool: compile:  clang++ -DHAVE_CONFIG_H -I. -I../../.. -I../../../src/lib -I../../../src/lib -I/opt/local/include -pthread -I../../../src/lib/util -I../../../src/lib/util -I../../../src/lib/dns -I../../../src/lib/dns -I../../../src/lib/nsas -I../../../src/lib/nsas -I../../../src/lib/cache -I../../../src/lib/cache -I/opt/local/include -I../../../ext/asio -I../../../ext/coroutine -DASIO_DISABLE_THREADS=1 -Wall -Wextra -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -Werror -fPIC -Wno-missing-field-initializers -Wno-unused-parameter -g -O2 -MT resolver_cache.lo -MD -MP -MF .deps/resolver_cache.Tpo -c resolver_cache.cc  -o .libs/resolver_cache.o
clang: warning: argument unused during compilation: '-c'
clang: warning: argument unused during compilation: '-D HAVE_CONFIG_H'
clang: warning: argument unused during compilation: '-I .'
clang: warning: argument unused during compilation: '-I ../../..'
clang: warning: argument unused during compilation: '-I ../../../src/lib'
clang: warning: argument unused during compilation: '-I ../../../src/lib'
clang: warning: argument unused during compilation: '-I /opt/local/include'
clang: warning: argument unused during compilation: '-I ../../../src/lib/util'
clang: warning: argument unused during compilation: '-I ../../../src/lib/util'
clang: warning: argument unused during compilation: '-I ../../../src/lib/dns'
clang: warning: argument unused during compilation: '-I ../../../src/lib/dns'
clang: warning: argument unused during compilation: '-I ../../../src/lib/nsas'
clang: warning: argument unused during compilation: '-I ../../../src/lib/nsas'
clang: warning: argument unused during compilation: '-I ../../../src/lib/cache'
clang: warning: argument unused during compilation: '-I ../../../src/lib/cache'
clang: warning: argument unused during compilation: '-I /opt/local/include'
clang: warning: argument unused during compilation: '-I ../../../ext/asio'
clang: warning: argument unused during compilation: '-I ../../../ext/coroutine'
clang: warning: argument unused during compilation: '-D ASIO_DISABLE_THREADS=1'
In file included from resolver_cache.cc:1:
resolver_cache.cc:231:16: error: out-of-line definition of 'dump' does not match any declaration in 'isc::cache::ResolverCache'
ResolverCache::dump(const std::string&) {
~~~~~~~~~~~~~~~^
resolver_cache.cc:236:16: error: out-of-line definition of 'load' does not match any declaration in 'isc::cache::ResolverCache'
ResolverCache::load(const std::string&) {
~~~~~~~~~~~~~~~^
2 errors generated.

comment:7 Changed 9 years ago by jinmei

  • Owner changed from jinmei to zhanglikun

comment:8 Changed 9 years ago by zhanglikun

  • Owner changed from zhanglikun to jinmei

Sorry for the error, what a naive mistake did by me.

I commit the change for file lib/cache/resolver_cache.cc, so please have a test again.

comment:9 Changed 9 years ago by jinmei

I've made and pushed a couple of minor editorial fixes.

Other than these it looks okay. Pleae merge it (and then check the review
queue for picking up an open review request:-)

comment:10 Changed 9 years ago by jinmei

  • Owner changed from jinmei to zhanglikun

comment:11 Changed 9 years ago by stephen

  • Estimated Difficulty changed from 0.0 to 1.0

comment:12 Changed 9 years ago by zhanglikun

  • Resolution set to fixed
  • Status changed from reviewing to closed

merged in git 4f714bac4547d0a025afd314c309ca5cb603e212, so close this ticket.

Note: See TracTickets for help on using tickets.