Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#62 closed defect (fixed)

review: NSEC RDATA implementation

Reported by: jinmei Owned by: each
Priority: high Milestone: 03. 1st Incremental Release
Component: libdns++ Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: Add Hours to Ticket:
Total Hours: Internal?:

Description

  • As usual, we need more tests.
  • the "from wire" constructor should be more strict on validation. see the test case and comment @ rev1100

Subtickets

Change History (3)

comment:1 Changed 10 years ago by each

Addressed in r1331. In NSEC3 as well. Added unit tests.

comment:2 Changed 10 years ago by each

  • Resolution set to fixed
  • Status changed from new to closed

comment:3 Changed 10 years ago by jinmei

not fully checked, but is the validation as strict as BIND9? From a quick look at the BIND9's fromwire_nsec(), it seems to do more sanity checks than r1331.

Note: See TracTickets for help on using tickets.