Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#593 closed task (duplicate)

sharing more code in NSEC and NSEC3

Reported by: jinmei Owned by: jinmei
Priority: medium Milestone:
Component: libdns++ Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 0.0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

This is a continuation from #117.

NSEC and NSEC3 classes should share more code for type bitmap processing.
I'd also propose using std::bitset in the "from text" constructor(s).
It would make the code more intuitive.

Subtickets

Change History (5)

comment:1 Changed 9 years ago by stephen

  • Milestone A-Team-Task-Backlog deleted

Milestone A-Team-Task-Backlog deleted

comment:2 follow-up: Changed 8 years ago by shane

  • Defect Severity set to N/A
  • Owner changed from UnAssigned to jinmei
  • Status changed from new to assigned
  • Sub-Project set to DNS

Jinmei, I'm not sure if this suggest still makes sense. I confess I haven't looked at the code. Please don't spend time researching it - I can do that - but if you know off the top of your head if this ticket is still valid let me know! Thanks.

comment:3 in reply to: ↑ 2 Changed 8 years ago by jinmei

  • Milestone set to New Tasks

Replying to shane:

Jinmei, I'm not sure if this suggest still makes sense. I confess I haven't looked at the code. Please don't spend time researching it - I can do that - but if you know off the top of your head if this ticket is still valid let me know! Thanks.

It's done. Closing.

comment:4 Changed 8 years ago by jinmei

  • Resolution set to duplicate
  • Status changed from assigned to closed

comment:5 Changed 8 years ago by shane

  • Milestone New Tasks deleted
Note: See TracTickets for help on using tickets.