Opened 10 years ago

Closed 10 years ago

#59 closed enhancement (fixed)

review: preliminary implementation of OPT RDATA

Reported by: jinmei Owned by: jinmei
Priority: very high Milestone: 03. 1st Incremental Release
Component: libdns++ Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: Add Hours to Ticket:
Total Hours: Internal?:

Description

Please review the following set of files as of trunk rev 1036:

rdata/generic/opt_41.h
rdata/generic/opt_41.cc
tests/rdata_opt_unittest.cc

(all under src/lib/dns/cpp/)

These implement a minimal level of EDNS OPT RR support for our year 1
deliverable. Should be very straightforward and easy to review.

Subtickets

Change History (3)

comment:1 Changed 10 years ago by jinmei

sorry, a testdata file missing. the target rev is now 1037.

comment:2 follow-up: Changed 10 years ago by each

I would copy the toText() behavior out of BIND 9 instead of returning an empty string, as we'll want to be able to inspect incoming packets for debugging reasons. Otherwise it seems fine.

In light of your comments about Tsig I'm wondering how you're planning to integrate this with Message?

comment:3 in reply to: ↑ 2 Changed 10 years ago by jinmei

  • Resolution set to fixed
  • Status changed from new to closed

Replying to each:

I would copy the toText() behavior out of BIND 9 instead of returning an empty string, as we'll want to be able to inspect incoming packets for debugging reasons. Otherwise it seems fine.

It's in my middle term plan, but I think it's a post-year1 fodder. To allows this we'll need to store the options in the "from wire" constructor, which will require more tests and more development/review time, more review-update cycles.

I see the benefit of debugging convenience even in an earlier stage, but for now, I think the time that can be saved by this simplification buys us more.

In light of your comments about Tsig I'm wondering how you're planning to integrate this with Message?

How to integrate EDNS with Message? For year1, I'll simply make it work in an "ugly, ad hoc" manner. Will consider a cleaner design (which may result in something not so different from the current design, though) post-year1.

I'm going to close this ticket.

Note: See TracTickets for help on using tickets.