#5705 closed enhancement (complete)

Global Host Reservations Task 2:Add v4 support for new HR_GLOBAL mode

Reported by: tmark Owned by: tmark
Priority: medium Milestone: Kea1.5
Component: Unclassified Version: git
Keywords: TDS Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

  1. Create new mode HR_GLOBAL mode and add to kea-dhpd4/subnet parsing
  2. Modify v4 AllocEngine::findReservation to utilize new mode

Subtickets

Change History (5)

comment:1 Changed 19 months ago by tmark

  • Owner set to tmark
  • Status changed from new to assigned

kea-dhcp4 now fully supports global HRs.

Ticket is ready for review.

Proposed ChangeLog?:

14xx.   [func]      tmark
    kea-dhcp4 now supports "global" host reservations and a new
    global reservations-mode .  Prior this to reservations could 
    only be specified per subnet.  This is supported by by Memfile,
    MySQL,PostgreSQL,and Cassandra host data sources.
    (Trac #5705, git TBD)

comment:2 Changed 19 months ago by tmark

  • Owner changed from tmark to UnAssigned
  • Status changed from assigned to reviewing

comment:3 Changed 19 months ago by tomek

  • Owner changed from UnAssigned to tomek

comment:4 Changed 19 months ago by tomek

  • Owner changed from tomek to tmark

I have reviewed the code. It looks good. I had some minor changes, so please pull and review.

In particular, make sure you review the guide update. We don't want any more polgrish in there.

Your changelog is good, but I would remove quotes around global. Also "Prior this to" => "Prior to this".

When merging the code, make sure you also push it to gitlab.

comment:5 Changed 19 months ago by tmark

  • Resolution set to complete
  • Status changed from reviewing to closed

Merged into gitlab git# f991cffd06add941f8bf2937232f51d597623e21

Added ChangeLog? entry 1443.

Ticket is complete.

Note: See TracTickets for help on using tickets.