#5646 closed enhancement (complete)

Better sanity checks against empty client-id and server-id options

Reported by: tomek Owned by: tomek
Priority: high Milestone: Kea1.4-final
Component: dhcp6 Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

After #5449 was merged, the code in getMACFromDUID no longer throws an exception if empty client-id was received. That exception accidentally caused Kea to not respond to packets with malformed client-id.

This ticket is about adding explicit checks for too short client-ids.

Subtickets

Change History (5)

comment:1 Changed 18 months ago by tomek

  • Owner set to Unassigned
  • Status changed from new to reviewing

Added dedicated checks. Please review.

Hopefully this will address the problem of 58 tests failing.

comment:2 Changed 18 months ago by wlodekwencel

I confirm, fix works. Thanks

comment:3 Changed 18 months ago by fdupont

  • Owner changed from Unassigned to fdupont

comment:4 Changed 18 months ago by fdupont

  • Owner changed from fdupont to tomek

Code looks fine and passes tests. Ready to be merged. BTW there is another ticket about empty option (hostname, cf an ISC DHCP recent fix).

comment:5 Changed 18 months ago by tomek

  • Resolution set to complete
  • Status changed from reviewing to closed

Thanks for the review and testing. Merged. Closing.

Note: See TracTickets for help on using tickets.