#5645 closed task (complete)

Move HA hook library to main repository

Reported by: marcin Owned by: marcin
Priority: high Milestone: Kea1.4-final
Component: high-availability Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

With the decision made to release HA library in open source, we need to move it to the Kea repository and update documentation, licenses etc.

Subtickets

Change History (6)

comment:1 Changed 17 months ago by marcin

  • Owner set to marcin
  • Status changed from new to accepted

comment:2 Changed 17 months ago by marcin

  • Owner changed from marcin to UnAssigned
  • Status changed from accepted to reviewing

I moved the HA lib from premium repo to the main repo. I updated the doxygen (.dox) as appropriate and it is now included in the main developer's guide as a subpage. I updated the copyright headers in all code files to MPLv2.0. Finally, the user's guide was updated to not refer to libdhcp_ha as premium hook. I hope I didn't miss anything.

Proposed ChangeLog entries:

premium:

XX.	[build]		marcin
	Moved libdhcp_ha (High Availability) hooks library from
	premium to main Kea repository and changed its license to
	MPLv2.0. Future ChangeLog entries for this library will be
	tracked in the Kea ChangeLog file.
	(Trac #5645, git cafe)

and really the same for the main repo.

comment:3 Changed 17 months ago by tomek

  • Owner changed from UnAssigned to tomek

comment:4 Changed 17 months ago by tomek

  • Owner changed from tomek to marcin

You did a very thorough job here. Thanks a lot.
All the copyright headers seem to be updated.

The new code builds correctly and unit-tests pass.

I have correct User's Guide. It stated HA is premium.
Please pull and review.

The only other place I has to update was this:
https://kea.isc.org/wiki/Hooks

On a related note, the only reason this list exists
is to allow non-ISC people to add their hooks.

Maybe we should change its format slightly to say
"ISC hooks: see user's guide. non-isc hooks, see below."

Agree the same changelog entry should be in both kea and premium
repos.

Tested on ubuntu 17.10 x64. Code builds and unit-tests pass.
Docs were updated. Developer's guide includes HA section.

comment:5 Changed 17 months ago by marcin

  • Internal? unset
  • Sensitive unset

comment:6 Changed 17 months ago by marcin

  • Resolution set to complete
  • Status changed from reviewing to closed

Thanks for the review and catching the "premium" leftover. As I don't see anything to be fixed here, I simply merge this change.

Premium merge commit: 3bb513e8b8e6b904a2994f77304da050ed194b0c
Main merge commit: 19b2553d4869bdd52b63b6f7969052d8a724f78d

Note: See TracTickets for help on using tickets.