#5639 closed defect (duplicate)

legldb_create.* legldb_drop.* scripts in premium repo

Reported by: wlodekwencel Owned by: UnAssigned
Priority: medium Milestone: Kea1.5
Component: Unclassified Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

there are 6 new databases scripts in premium repo:

  • legldb_create.mysql legldb_drop.mysql
  • legldb_create.cql legldb_drop.cql
  • legldb_create.psql legldb_drop.psql
  1. is there a typo in names? shouldn't it be legal_db* ?
  2. why do we need 6 scripts to add/remove one table from db schema? couldn't it be integrated to main kea db schema?
  3. those scripts are not being installed - that have to be fixed.

Subtickets

Change History (6)

comment:1 Changed 18 months ago by tomek

Thanks for asking those questions.

I think the best way forward is to add those tables to respective creation schemas in base Kea and remove those extra scripts.

Yes, that will require schema update, but users won't really need to update unless they're using forensic logging.

comment:2 Changed 17 months ago by fdupont

The last point (failed to be installed) should be checked as Makefile.am files where copied from similar Kea core code...

comment:3 Changed 17 months ago by fdupont

I confirm the bug: SHARE_DIR is not set to share in config.m4 as it should be (and was when tier1 was included).
I suggest to address this (and only this) in 1.4-final.

comment:4 Changed 17 months ago by fdupont

  • Owner set to fdupont
  • Status changed from new to accepted

Part of #5584.

comment:5 Changed 16 months ago by fdupont

  • Milestone changed from Kea-proposed to Kea1.5
  • Owner changed from fdupont to UnAssigned
  • Status changed from accepted to reviewing

Done in premium in the trac5584 ticket.
Ready for review.

comment:6 Changed 15 months ago by tomek

  • Resolution set to duplicate
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.