#5625 closed defect (fixed)

Warning in the CQL stats query code about override

Reported by: marcin Owned by: tmark
Priority: medium Milestone: Kea1.4-final
Component: database-cassandra Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

While sanity checking the Kea-1.4.0 I got quite a few warnings like this:

../../../../src/lib/dhcpsrv/cql_lease_mgr.h:383:32: warning: 'startLeaseStatsQuery4' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
    virtual LeaseStatsQueryPtr startLeaseStatsQuery4();

Those have to be looked at and resolved, possibly for final release.

Subtickets

Change History (7)

comment:1 Changed 13 months ago by tmark

  • Owner set to tmark
  • Status changed from new to assigned

comment:2 Changed 13 months ago by tmark

  • Milestone changed from Kea-proposed to Kea1.4-final

comment:3 Changed 13 months ago by tmark

  • Owner changed from tmark to UnAssigned
  • Status changed from assigned to reviewing

Ready for review.

ChangeLog:

14xx.   [bug]       tmark
    Corrected missing "override" warning in cql_lease_mgr.h
    (Trac #5625, git TBD)

comment:4 Changed 13 months ago by fdupont

IMHO no ChangeLog is needed (note this is an opinion expressed when I was reading my message, it is not a review).

comment:5 follow-up: Changed 13 months ago by fdupont

  • Owner changed from UnAssigned to tmark

Look at the code: seems sane. so if it fixes warnings (and I believe you checked that) it is ready for merging.

comment:6 in reply to: ↑ 5 Changed 13 months ago by tmark

Replying to fdupont:

Look at the code: seems sane. so if it fixes warnings (and I believe you checked that) it is ready for merging.

Yes, I did verify the warnings are gone and CQL unit tests pass under MacOS.

comment:7 Changed 13 months ago by tmark

  • Resolution set to fixed
  • Status changed from reviewing to closed

merged with git# df3068ba0e520df4d96dd38e2de679beb99f2e23

Added ChangeLog? entry 1405.

ticket is complete.

Note: See TracTickets for help on using tickets.