#5621 closed enhancement (complete)

HA: Do not synchoronize lease database when database replication is in use

Reported by: marcin Owned by: marcin
Priority: medium Milestone: Kea1.4-final
Component: high-availability Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

Kea HA library supports send-lease-updates parameter which disables lease updates upon allocation or renewal of leases. This however doesn't control whether the server synchronizes its lease database during startup. The best solution may be to not synchronize the lease database when this parameter is set to false. Even better, we may rename this parameter to something better desribing its function in that case, e.g. share-lease-info.

Subtickets

Change History (6)

comment:1 Changed 10 months ago by tomek

  • Milestone changed from Kea-proposed to Kea1.4-final

comment:2 Changed 10 months ago by marcin

  • Owner set to marcin
  • Status changed from new to accepted

comment:3 Changed 10 months ago by marcin

  • Owner changed from marcin to UnAssigned
  • Status changed from accepted to reviewing

I added a new parameter which controls whether the lease synchronization should be performed or not. If it is disabled, the server will bypass the synchronization state and will issue appropriate log messages. I also made some logging improvements which pertain to the "send-lease-updates" parameter.

Proposed ChangeLog entry for premium repo:

XX.	[func]		marcin
	Added "sync-leases" boolean configuration parameter in the
	HA hooks library. It allows for disabling the lease database
	synchronization between the active servers.
	(Trac #5621, git cafe)

and for main repo:

14XX.	[doc]		marcin
	Documented "sync-leases" configuration parameter of the HA
	hooks library in the Kea Administrator's Manual.
	(Trac #5621, git cafe)

comment:4 Changed 10 months ago by tmark

  • Owner changed from UnAssigned to tmark

comment:5 Changed 10 months ago by tmark

  • Owner changed from tmark to marcin

Changes are straight forward but I wonder if logConfigStatus() should perhaps have an additional log for when send-lease-updates and sync-leases are different? Yes, they could infer that from the existing messages, but we might want to point out to them specifically that this is an unusual configuration.

I'll leave the decision to you.

Builds and unit tests pass under Centos 7.

comment:6 Changed 10 months ago by marcin

  • Resolution set to complete
  • Status changed from reviewing to closed

I added the additional warning message as suggested and merged with commits 4ebac3a411aa02d1cc3d74e7eaf3212ad208159a and 2248eb2a58731adc1d13784a5a4948911d5d651c (premium).

Note: See TracTickets for help on using tickets.