#5619 closed defect (fixed)

Hook release script requires improvements

Reported by: tomek Owned by: wlodekwencel
Priority: high Milestone: Kea1.4
Component: Unclassified Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no


Wlodek reported issues with the current repack-premium script:

  1. tarballs contain additional files that overwrite files from Kea repo.
  1. subscribers tarball is incomplete (contains only legal_log, flex_id, host_cmds and high_availability, but the last one is only empty directory).


Change History (4)

comment:1 Changed 22 months ago by tomek

I looked at the problem and the issue 2 is a side effect of previously building premium (which removed some files and directories). This can be fixed by doing:

cd premium;
git reset --hard
git clean -fxd

The issue 1 is still outstanding.

Furthermore, we need packages for (flex-id, radius, host-cache) and (ha).

comment:2 Changed 22 months ago by tomek

  • Owner set to tomek
  • Status changed from new to assigned

comment:3 Changed 22 months ago by tomek

  • Owner changed from tomek to wlodekwencel
  • Status changed from assigned to reviewing

Ok, I wrote a new script called premium/tools/package-hooks. It starts with some introductory comments that you are highly recommended to read.

Here are the core points:

  1. to prepare kea tarball use open source repo without premium/.
  1. to prepare hook tarballs, use kea repo with premium. Make sure all changes you mare are committed, then run the script from top kea directory:
premium/tools/package-hooks 'hooks to be removed' suffix [extra params to configure]
  1. The tarballs don't overwrite anything in main kea repo. The downside is that you need to call autoreconf -i after hook tarballs are extracted.

There's also example script (premium/tools/package-all) that prepares all combinations of hooks that we need for 1.4.

The changes are on trac5619 in both (main and premium) repos.

Last edited 22 months ago by tomek (previous) (diff)

comment:4 Changed 22 months ago by tomek

  • Resolution set to fixed
  • Status changed from reviewing to closed

As discussed with Wlodek over jabber, merging the code.
Paths for forensic_log have been updated.

Note: See TracTickets for help on using tickets.