#5615 closed defect (fixed)

Asio use threads but build flag still says the opposite.

Reported by: fdupont Owned by: fdupont
Priority: medium Milestone: Kea1.4-final
Component: build system Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

Change BOOST_ASIO_DISABLE_THREADS in configure to reflect the current use of threads by boot asio. Note this is a suspect in random crashes in unit tests using both asio and threads.

Subtickets

Change History (6)

comment:1 Changed 14 months ago by fdupont

After a large number of make check in radius hook no crash happened so IMHO it is the right fix.

comment:2 Changed 13 months ago by tomek

  • Milestone changed from Kea-proposed to Kea1.4-final

Ok, let's try to fix this in 1.4-final.

comment:3 Changed 13 months ago by fdupont

  • Owner set to fdupont
  • Status changed from new to accepted

comment:4 Changed 13 months ago by fdupont

  • Owner changed from fdupont to UnAssigned
  • Status changed from accepted to reviewing

Proposed ChangeLog entry (for the code itself only a comment has to be introduced):
Commented out BOOST_ASIO_DISABLE_THREADS in configure to reflect the current use of threads by boost ASIO in Kea.
Ready for review (no branch).

comment:5 Changed 13 months ago by marcin

  • Owner changed from UnAssigned to fdupont

When tried this proposed change I got flooded with those warnings:

/usr/local/Cellar/boost/1.62.0/include/boost/asio/detail/macos_fenced_block.hpp:45:5: warning: 'OSMemoryBarrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_thread_fence() from <atomic> instead [-Wdeprecated-declarations]
    OSMemoryBarrier();

I am not necessarily saying this is a show stopper but it would be good to know how to prevent this issue (upgrading boost?) and how that affects our current builds on Jenkins?

comment:6 Changed 13 months ago by fdupont

  • Resolution set to fixed
  • Status changed from reviewing to closed

Likely upgrading boost (brew current boost is 1.67.0_1)...
I am doing the change and closing the ticket.

Note: See TracTickets for help on using tickets.