#5604 closed enhancement (complete)

HA: Implement send-lease-updates parameter to disable lease updates for the database replication case

Reported by: marcin Owned by: marcin
Priority: medium Milestone: Kea1.4
Component: high-availability Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

When the HA is achieved by setting up the SQL database replication we don't need to send lease updates to the partner. We need a configuration parameter to disable it in HA hook library.

Subtickets

Change History (8)

comment:1 Changed 19 months ago by marcin

  • Milestone changed from Kea-proposed to Kea1.4

Moving to 1.4 per Kea call on April 26th.

comment:2 Changed 19 months ago by marcin

  • Owner set to marcin
  • Status changed from new to accepted

comment:3 Changed 19 months ago by marcin

  • Owner changed from marcin to UnAssigned
  • Status changed from accepted to reviewing

I added 'send-lease-updates' parameter which can be used to turn off lease updates. I also realized that the logic for 'auto-failover' parameter was never added, so I added it now and made the parameter optional.

Proposed ChangeLog entry:

XX.	[func]		marcin
	Added 'send-lease-updates' parameter into the HA hook library
	configuration, which can be used to disable/enable sending
	lease updates to the HA peer. Also, implemented the logic
	for 'auto-failover' configuration parameter.
	(Trac #5604, git cafe)

comment:4 Changed 19 months ago by tmark

  • Owner changed from UnAssigned to tmark

comment:5 follow-up: Changed 19 months ago by tmark

  • Owner changed from tmark to marcin

src/hooks/dhcp/high_availability/ha_messages.mes

+% HA_CONFIG_AUTO_FAILOVER_DISABLED auto-failover disabled for %1
+This warning message is issued to indicate that the 'auto-failover' parameter
+was set to false for the specified server. The server will not automatically
+start serving partner's scope when the partner failure is detected.
+The server administrator will need to enable this scope manually by
+sending appropriate ha-scopes command.

I think you should change "was set to false" to "administratively disabled"
as you do for HA_CONFIG_LEASE_UPDATES_DISABLED. This makes it clear that
it was done by someone by the code.

---

What about the user's guide? Does it include these parameters?

Other than that, changes are fine, HA unit tests pass under Ubuntu 16.04.

comment:6 in reply to: ↑ 5 Changed 19 months ago by marcin

  • Owner changed from marcin to tmark

Replying to tmark:

src/hooks/dhcp/high_availability/ha_messages.mes

+% HA_CONFIG_AUTO_FAILOVER_DISABLED auto-failover disabled for %1
+This warning message is issued to indicate that the 'auto-failover' parameter
+was set to false for the specified server. The server will not automatically
+start serving partner's scope when the partner failure is detected.
+The server administrator will need to enable this scope manually by
+sending appropriate ha-scopes command.

I think you should change "was set to false" to "administratively disabled"
as you do for HA_CONFIG_LEASE_UPDATES_DISABLED. This makes it clear that
it was done by someone by the code.

Updated.

---

What about the user's guide? Does it include these parameters?

Tomek is reviewing the User's Guide right now as part of another ticket. I don't want to introduce changes to the guide while he is reviewing. When the guide gets reviewed I will add info about those parameters. In fact, the auto-failover is probably already documented. The other one is missing.

Other than that, changes are fine, HA unit tests pass under Ubuntu 16.04.

comment:7 Changed 19 months ago by tmark

  • Owner changed from tmark to marcin

Changes are good to go. Please merge.

comment:8 Changed 19 months ago by marcin

  • Resolution set to complete
  • Status changed from reviewing to closed

Merged with commit 52cbda3f95084ad0b493d514049a4f4ecd5bf795

Note: See TracTickets for help on using tickets.