Opened 9 months ago

Closed 9 months ago

#5590 closed task (complete)

Install required header files with Kea

Reported by: marcin Owned by: marcin
Priority: medium Milestone: Kea1.4
Component: build system Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

We tend to forget to include header files which should be installed with Kea in the _include_HEADERS. One such example is src/lib/hooks/parking_lot.h, but I am sure there are other missing headers as well. We should go over all libs and include required (or maybe all) header files for the 1.4 beta release.

Subtickets

Change History (7)

comment:1 Changed 9 months ago by tomek

  • Milestone changed from Kea-proposed to Kea1.4
  • Type changed from defect to task

As discussed on previous call, moving to 1.4.

comment:2 Changed 9 months ago by marcin

  • Owner set to marcin
  • Status changed from new to accepted

comment:3 Changed 9 months ago by marcin

  • Owner changed from marcin to UnAssigned
  • Status changed from accepted to reviewing

I updated Makefiles.am where appropriate to install new header files, introduced since Kea 1.3 release. I also bumped up version numbers of Kea libs for 1.4 release.

Proposed ChangeLog entry:

13XX.	[build]		marcin
	Install new header files introduced since Kea 1.3 release.
	Also, bumped up libraries version numbers for Kea 1.4 beta
	release.
	(Trac #5590, git cafe)

comment:4 Changed 9 months ago by marcin

I didn't update the Kea hooks framework version numbers because I am not sure if the changes we have made to the framework require this. I think not, but we can always update later if we think it is required to recompile old hooks.

comment:5 Changed 9 months ago by fdupont

  • Owner changed from UnAssigned to fdupont

comment:6 Changed 9 months ago by fdupont

  • Owner changed from fdupont to marcin

Looks fine. Two comments:

  • library versions were bumped. It was something to do but was it the right time? (IMHO beta is close enough so I have no concern)
  • there were a significant number of forgotten headers so it should be really fine to have an automatic tool to detect them.

comment:7 Changed 9 months ago by marcin

  • Resolution set to complete
  • Status changed from reviewing to closed

Merged with commit 64351229a30832735c5a81ac17ca1521aa2483b2

Note: See TracTickets for help on using tickets.