#5585 closed enhancement (complete)

Implement main support for Shared Lease Storage Stats for Memfile

Reported by: tmark Owned by: tmark
Priority: medium Milestone: Kea1.4
Component: database-memfile Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket: shared lease statistics
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

Implement the changes described in section 4.1 of the Shared Lease Stats
Design (http://kea.isc.org/wiki/SharedLeaseStorageStats) for Memfile:

4.1.3 Extend the LeaseStatsQuery class and derivations
4.1.4 Overload !LeaseMgr::startLeaseStatsQuery<4/6>

This allows Memfile users to benefit from the where clauses and result-set format provided by the lease statistics commands. The extensions created
here will be built upon by other back end derivations.

Subtickets

Change History (5)

comment:1 Changed 20 months ago by tmark

  • Owner set to tmark
  • Status changed from new to assigned

comment:2 Changed 20 months ago by tmark

  • Milestone changed from Kea-proposed to Kea1.4
  • Owner changed from tmark to UnAssigned
  • Status changed from assigned to reviewing

LeaseStatsQuery, LeaseMgr, and unittests have all been extended to support query variants
v4/v6 MemfileLeaseMgr? derivations are complete and fully functional

As this is internal, I do not think we need a ChangeLog.

Ready for Review

comment:3 Changed 19 months ago by marcin

  • Owner changed from UnAssigned to marcin

comment:4 follow-up: Changed 19 months ago by marcin

  • Owner changed from marcin to tmark

I reviewed commit 3c2897f7747dc75c3f7a5c53362e900e88a83a44.

The changes are straight forward. I fixed a couple of little typos, coding style and passing object by reference rather than by value. The code is ready for merging, but please remember to pull and review my changes first.

comment:5 in reply to: ↑ 4 Changed 19 months ago by tmark

  • Resolution set to complete
  • Status changed from reviewing to closed

Replying to marcin:

I reviewed commit 3c2897f7747dc75c3f7a5c53362e900e88a83a44.

The changes are straight forward. I fixed a couple of little typos, coding style and passing object by reference rather than by value. The code is ready for merging, but please remember to pull and review my changes first.

Changes are fine, thank you.

Merged with git #6c3c1afdec57bfecf35d6a4956eefdabe8815a29

Ticket is complete.

Note: See TracTickets for help on using tickets.