#5567 closed defect (fixed)

Flag --with-dhcp-mysql and --with-dhcp-pgsql as invalid or support them

Reported by: tmark Owned by: tmark
Priority: low Milestone: Kea1.4
Component: build system Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

The config parameters --with-dhcp-* were altered by another ticket in 1.4 to drop the "-dhcp". This is all well and good except, the configure script does not fail with --with-dhcp-* as invalid.

Either the script should fail with an error or we should support them as matter of backward compatibility. It's a big waste of time for them to be quietly accepted without yielding the expected build.

Subtickets

Change History (8)

comment:1 Changed 12 months ago by tomek

  • Component changed from Unclassified to build system
  • Milestone changed from Kea-proposed to Kea1.4
  • Priority changed from high to low

As discussed today, moving to 1.4 as low. The consensus it to add support for the old parameters (and maybe produce a warning if --with-dhcp-X is used instead of --with-X).

comment:2 Changed 12 months ago by tmark

  • Owner set to tmark
  • Status changed from new to assigned

comment:3 Changed 12 months ago by tmark

  • Owner changed from tmark to UnAssigned
  • Status changed from assigned to reviewing

Ready for review.

ChangeLog:

13xx.   [build]     tmark
    Modified configure script to support --with-dhcp-mysql and
    --with-dhcp-pgsql but emit a deprecation warning message
    encouraging their replacement with --with-mysql and --with-pgsql.
    (Trac #5567, git TBD)

comment:4 follow-up: Changed 12 months ago by fdupont

A warning is not enough: you have already a warning on unrecognized options so adding another one won't change people who do not care...

comment:5 in reply to: ↑ 4 Changed 12 months ago by tmark

Replying to fdupont:

A warning is not enough: you have already a warning on unrecognized options so adding another one won't change people who do not care...

Perhaps you misunderstood the changes. The options --with-dhcp-<mysql/pgsql> were changed to --with-<mysql/pgsql> by an earlier 1.4 ticket, which left the script quietly ignoring them causing builds to complete successfully without support for the desired back ends.

This ticket does TWO things:

  1. Allows either form of the options to be used
  2. Emits a specific deprecation warning message when older form is used

This is the behavior that was discussed and agreed upon during weekly Kea call.

comment:6 Changed 11 months ago by tomek

  • Owner changed from UnAssigned to tomek

comment:7 Changed 11 months ago by tomek

  • Owner changed from tomek to tmark

Thomas is right. The change is not about issuing extra warning, but about maintaining backward compatibility for a release or two.

I have reviewed those changes and they look good. The warning is properly emitted when obsolete form is used.

Also, on my mac os (pretty standard setup with packages installed using brew), the configure couldn't detect the location properly. I've updated it slightly.

My changes pushed to trac5567.

Please test those changes on a system other than mac os. If it works, it's ready to go.

comment:8 Changed 11 months ago by tmark

  • Resolution set to fixed
  • Status changed from reviewing to closed

Tomek's changes work fine under Ubuntu 16.04

Merged with git #53761069761ddde44636baa30185322debfe4186
Added ChangeLog? entry 1388.

ticket is complete.

Note: See TracTickets for help on using tickets.