Opened 2 years ago

Closed 22 months ago

#5565 closed defect (fixed)

Update callout handle store

Reported by: fdupont Owned by: marcin
Priority: medium Milestone: Kea1.4
Component: high-availability Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

From callout_handle_store.h:

/// @note If the behaviour of the server changes so that multiple packets can
///       be active at the same time, this simplistic approach will no longer
///       be adequate and a more complicated structure (such as a map) will
///       be needed.

I am afraid it is time now... Note it is clearly for 1.4 as we can't distribute code
where the hook support is too easy to break. Fortunately it is pretty independent.
I put is in HA because it is where the park belongs.

Subtickets

Change History (7)

comment:1 Changed 2 years ago by tomek

  • Milestone changed from Kea-proposed to Kea1.4

This is a deficiency in the current code that became important with the addition of the ability to park a packet. As discussed today, moving to 1.4 as medium.

comment:2 Changed 22 months ago by marcin

  • Owner set to marcin
  • Status changed from new to accepted

comment:3 Changed 22 months ago by marcin

  • Owner changed from marcin to UnAssigned
  • Status changed from accepted to reviewing

Updated CalloutHandleStore? to hold multiple handles. As this is an internal change, it probably doesn't require any change log entry.

comment:4 Changed 22 months ago by tomek

  • Owner changed from UnAssigned to tomek

comment:5 Changed 22 months ago by fdupont

BTW reading shared pointer docs is instructing:

  • standard (vs boost as we use) shared pointers has unique deprecated in C++17
  • standard shared pointers unique and use_count are an approximation with threading
  • for boost shared pointers unique should be used vs use_count.

I can't conclude something in the long term about that...

comment:6 Changed 22 months ago by tomek

  • Owner changed from tomek to marcin

I have reviewed those changes. They look good.

Although it's an internal change, I think it's useful to let the hook developers know that the internals has changed. As such, I think this requires a ChangeLog? entry.

Please merge.

The code builds and unit-tests pass on Ubuntu 17.10.

comment:7 Changed 22 months ago by marcin

  • Resolution set to fixed
  • Status changed from reviewing to closed

Merged with commit c14d735860b9894e3ea554df4ba5f0bc7dca3466

Note: See TracTickets for help on using tickets.