#5563 closed enhancement (complete)

get rid of unused host by hwaddr and/or duid get methods.

Reported by: fdupont Owned by: fdupont
Priority: medium Milestone: Kea1.4-final
Component: database-all Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

Cf #5528.

Subtickets

Change History (10)

comment:1 Changed 16 months ago by tomek

  • Milestone changed from Kea-proposed to Kea1.4-final

comment:2 Changed 13 months ago by fdupont

  • Owner set to fdupont
  • Status changed from new to accepted

comment:3 Changed 13 months ago by fdupont

  • Owner changed from fdupont to UnAssigned
  • Status changed from accepted to reviewing

Done... A lot of obsolete and unused code removed!
Ready for review.

comment:4 Changed 13 months ago by marcin

  • Owner changed from UnAssigned to marcin

comment:5 Changed 13 months ago by marcin

  • Owner changed from marcin to fdupont

I am afraid that the host cache hooks library must be updated to not use those removed functions. Please do it and I'll re-review.

comment:6 Changed 13 months ago by fdupont

  • Owner changed from fdupont to marcin

I did this in trac5563 premium branch (there are two commits because RADIUS also has a host backend). Note as these backends are child/derived classes when you forget something it is not very visible...

comment:7 Changed 13 months ago by tomek

  • Priority changed from low to medium

Great to see this dead code being removed. Bumping up priority to medium.

comment:8 Changed 13 months ago by marcin

  • Owner changed from marcin to fdupont

I reviewed your changes both in the main repo and in the premium repo. The unit tests pass now and I don't see anything wrong in the code. You can merge this. However, this is quite an intrusive change because it removes the APIs that have been there for quite a long time. If anyone has hooks libraries using them they will get into trouble. I think it is fine, but you should provide a clear ChangeLog entry indicating that this incompatible change has been introduced. In addition, we need to bump up the library major version number for the 1.4 release. Finally, the release notes must clearly state that we have made this change.

comment:9 follow-up: Changed 13 months ago by fdupont

Merged but not closing as there are some actions for the release engineer.

comment:10 in reply to: ↑ 9 Changed 13 months ago by marcin

  • Resolution set to complete
  • Status changed from reviewing to closed

Replying to fdupont:

Merged but not closing as there are some actions for the release engineer.

I updated the release notes to mention this incompatible change, so I am closing this ticket.

Note: See TracTickets for help on using tickets.