Opened 2 years ago

Closed 22 months ago

#5558 closed enhancement (complete)

HA: implement check-secs-byte-order in Kea

Reported by: marcin Owned by: tmark
Priority: low Milestone: Kea1.4
Component: high-availability Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

In the review of #5476 Thomas pointed out that some (mostly Windows) clients may put value of secs field in the wrong order. The ISC DHCP has a check-secs-byte-order flag which enables "detection" of reverse byte order. We may need similar configuration flag in Kea. Or simply enable this feature without any configuration knob.

Subtickets

Change History (5)

comment:1 Changed 23 months ago by tomek

  • Milestone changed from Kea-proposed to Kea1.4
  • Priority changed from medium to low

As discussed on 2018-03-29 call, accepting in 1.4 as low.

comment:2 Changed 22 months ago by marcin

  • Owner set to marcin
  • Status changed from new to accepted

comment:3 Changed 22 months ago by marcin

  • Owner changed from marcin to UnAssigned
  • Status changed from accepted to reviewing

Implemented the bytes swap detection in the same way as it is implemented in ISC DHCP. Unlike ISC DHCP, this detection is always ON.

Proposed ChangeLog entry:

XX.	[func]		marcin
	HA hook library handles the case when misbehaving clients
	swap "secs" field bytes. The "secs" field value is used to
	detect HA partner failures.
	(Trac #5558, git cafe)

comment:4 Changed 22 months ago by tmark

  • Owner changed from UnAssigned to tmark

comment:5 Changed 22 months ago by marcin

  • Resolution set to complete
  • Status changed from reviewing to closed

Merged with commit 64f06838f53b40356277cb271521480688ebf7bb

Note: See TracTickets for help on using tickets.