#5553 closed defect (complete)

kea-dhcp4 DHCP4_PACKET_DROP_0006 with message type of 0 is misleading

Reported by: tmark Owned by: tmark
Priority: high Milestone: Kea1.4
Component: dhcp4 Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

Message type of 0 equates to DHCP_NOTYPE and is returend by Pkt4->getType() when there is no option 53. We should explicitly log that differently then
message types we do not support.

Subtickets

Change History (6)

comment:1 Changed 11 months ago by tmark

  • Owner set to tmark
  • Status changed from new to assigned

comment:2 Changed 11 months ago by tomek

  • Component changed from Unclassified to dhcp4
  • Milestone changed from Kea-proposed to Kea1.4
  • Priority changed from medium to high

This affects one of our customers. We should treat it with high priority.

comment:3 Changed 11 months ago by tmark

  • Owner changed from tmark to UnAssigned
  • Status changed from assigned to reviewing

Ready for review.

ChangeLog?:

13xx.   [func]      tmark
    kea-dhcp4 now explicitly logs packets dropped due to a lack 
    of message type (option 53) as a log type DHCP4_PACKET_DROP_0009. 
    Prior to this such packets were logged has having an unsupported
    message type of 0.
    (Trac #5553, git TDB)

comment:4 Changed 11 months ago by tomek

  • Owner changed from UnAssigned to tomek

comment:5 Changed 11 months ago by tomek

  • Owner changed from tomek to tmark

I have reviewed your changes. They look good, but I have two minor comments:

  1. The PACKET_DROP_0009 message should be printed on INFO, not DEBUG level. Dropping a packet is in my opinion significant enough to use INFO.
  1. The check for message type being greater than LEASEQUERYDONE is no longer correct. RFC7724 specified LEASEQUERYSTATUS (17) and DHCPTLS (18). Please add both of them to dhcp4.h, change the condition and the code will be ready to go.

Your changelog looks good, the code compiled and unit-tests passed on Ubuntu 17.04.

comment:6 Changed 11 months ago by tmark

  • Resolution set to complete
  • Status changed from reviewing to closed

I have made the revisions requested and merged the ticket with git ff97e5ffb5f3478be71aae8130b6eff3208bd69a

ChangeLog? #1366 added.

Ticket is complete.

Note: See TracTickets for help on using tickets.