Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#5550 closed defect (worksforme)

Use hash as unsigned.

Reported by: fdupont Owned by: fdupont
Priority: medium Milestone: Kea1.4
Component: database-cassandra Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

Both because hashes are naturally unsigned, second because the cast drops the first bit.
But at the other hand it is not enough to update the schema, so IMHO it should be done at the next ticket merge where the schema must be updated.

Subtickets

Change History (4)

comment:1 Changed 2 years ago by tomek

Please put a comment in https://github.com/isc-projects/kea/pull/70 explaining this change and close this ticket.

comment:2 Changed 2 years ago by fdupont

  • Owner set to fdupont
  • Status changed from new to accepted

Comment posted. Waiting for answer/acknowledgment.

comment:3 Changed 2 years ago by fdupont

  • Resolution set to worksforme
  • Status changed from accepted to closed

Rejected:

  • C++ does not drop bits on unsigned/signed conversions of integers of the same size.
  • the proposed change breaks something else.

comment:4 Changed 2 years ago by tomek

  • Milestone changed from Kea-proposed to Kea1.4
Note: See TracTickets for help on using tickets.