#5494 closed defect (fixed)

Cassandra does not compile on macOS

Reported by: fdupont Owned by: fdupont
Priority: medium Milestone: Kea1.4
Component: database-cassandra Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description (last modified by fdupont)

Seems minor tweaks. I am merging previous ticket (#5493) in this one.

Subtickets

Change History (10)

comment:1 Changed 18 months ago by fdupont

  • Description modified (diff)
  • Owner set to fdupont
  • Status changed from new to accepted

comment:2 Changed 18 months ago by fdupont

Fixed everything which made "make check" to fail. Note if in general it is not portable (i.e. Linux specific) usual command line tools there are some points which are platform independent bugs (e.g. drop script not removing dhcp[46]_options tables).

Ready for review.

comment:3 Changed 18 months ago by tomek

  • Milestone changed from Kea-proposed to Kea1.4

comment:4 Changed 18 months ago by fdupont

HWADDR_SOURCE_DOCSIS_MODEM (128) is missing from the CQL schema.

comment:5 Changed 18 months ago by fdupont

  • Owner changed from fdupont to UnAssigned
  • Status changed from accepted to reviewing

comment:6 Changed 17 months ago by fdupont

Added PR 61.

comment:7 follow-up: Changed 17 months ago by tomek

  • Owner changed from UnAssigned to tomek

Your changes are good to go. Please merge, but I do have couple comments:

  1. Next time please don't include random unrelated fixes, like PR#61
  2. When you merge the code (with PR#61, make sure you add separate ChangeLog? entry for it and include the original submitted in AUTHORS file).
  3. I don't see any commits that add HWADDR_SOURCE_DOCSIS_MODEM. Did you forget to push?
  4. I don't think the rename you did with cql_config_defines.sh to cql_config_defines.sh.sample make much sense. There's a separate ticket #5488 that will remove that file altogether. Anyway, the change can go in as it.

This change requires a changelog entry. Here's my proposal if you don't have any better text:

13XX.	[build]		fdupont
	Cassandra compilation fixes for Mac OS.
	(Trac #5494, git tbd)

comment:8 Changed 17 months ago by tomek

  • Owner changed from tomek to fdupont

comment:9 in reply to: ↑ 7 Changed 17 months ago by fdupont

Replying to tomek:

Your changes are good to go. Please merge, but I do have couple comments:

  1. Next time please don't include random unrelated fixes, like PR#61

=> PR61 was in the same file so a related entry (the only difference was PostgreSQL vs Cassandra). BTW it was not clear all fixes were specific to Cassandra.

  1. When you merge the code (with PR#61, make sure you add separate ChangeLog? entry for it and include the original submitted in AUTHORS file).

=> I'll do it.

  1. I don't see any commits that add HWADDR_SOURCE_DOCSIS_MODEM. Did you forget to push?

=> no, I did not fix this one. I'll jabber to know if I should do.

  1. I don't think the rename you did with cql_config_defines.sh to cql_config_defines.sh.sample make much sense. There's a separate ticket #5488 that will remove that file altogether. Anyway, the change can go in as it.

=> I renamed it because reloading the source overwrote it: config files should not use their effective names. But it is a detail as this will be replaced by more standard way to configure.

This change requires a changelog entry. Here's my proposal if you don't have any better text:

13XX.	[build]		fdupont
	Cassandra compilation fixes for Mac OS.
	(Trac #5494, git tbd)

=> macOS (current official name of the OS), and compilation -> build as most of fixes are in shell scripts.

comment:10 Changed 17 months ago by fdupont

  • Resolution set to fixed
  • Status changed from reviewing to closed

Merged. Closing.

Note: See TracTickets for help on using tickets.