#5472 closed enhancement (complete)

force-create switch in lease4-update

Reported by: tomek Owned by: marcin
Priority: medium Milestone: Kea1.4
Component: management API Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

We already have lease4-update command. It can update existing leases. However, in failover scenarios it is not always clear whether a lease is already present or not. Therefore we need a switch - force-create - that will add the lease if missing.

For v6, see #5473.

Subtickets

Change History (4)

comment:1 Changed 15 months ago by marcin

  • Owner set to marcin
  • Status changed from new to accepted

comment:2 Changed 15 months ago by marcin

  • Owner changed from marcin to UnAssigned
  • Status changed from accepted to reviewing

This ticket is now ready for review. Proposed ChangeLog entry:

13XX.	[func]		marcin
	Implemented "force-create" parameter for lease4-update and
	lease6-update commands.
	(Trac #5472, git cafe)

This really also covers v6 part described in #5473.

comment:3 Changed 15 months ago by tmark

  • Owner changed from UnAssigned to marcin

The changes for this are straight forward, I think it is safe to merge.
Builds and unit test pass under MacOS.

I am a bit surprised that there are no unit tests for Lease<4/6>Parser class themselves. However, I'm not going to insist you add them now.

comment:4 Changed 14 months ago by marcin

  • Resolution set to complete
  • Status changed from reviewing to closed

Merged with commit 369245e4c5308a701fd483123f2cb2fd7d3d0966

Note: See TracTickets for help on using tickets.