Opened 2 years ago

Closed 23 months ago

#5403 closed defect (fixed)

DHCPv6 server should send prefix with zero lifetimes for old prefix lease

Reported by: marcin Owned by: marcin
Priority: medium Milestone: Kea1.4
Component: dhcp6 Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

The DHCPv6 server doesn't send prefixes with zero lifetimes for delegated prefixes which should no longer be used. Oddly enough, we do send addresses with zero lifetimes. There is a todo in the DHCPv6 server code saying that we should iterate over "old leases" (prefixes) and send them with zero lifetimes.

Subtickets

Change History (6)

comment:1 Changed 2 years ago by marcin

  • Milestone changed from Kea-proposed to Kea1.4

Move to Kea 1.4 per Kea team meeting on November 2nd, 2017

comment:2 Changed 2 years ago by marcin

  • Owner set to marcin
  • Status changed from new to accepted

comment:3 Changed 2 years ago by marcin

  • Owner changed from marcin to UnAssigned
  • Status changed from accepted to reviewing

I made the change for symmetry with IA_NA case.

Proposed ChangeLog:

13XX.	[bug]		marcin
	DHCPv6 server always sends prefixes with the lifetime of 0 for
	the prefix leases that should no longer be used, even if those
	prefixes are not included in the Renew/Rebind.
	(Trac #5403, git cafe)

comment:4 Changed 23 months ago by fdupont

  • Owner changed from UnAssigned to fdupont

comment:5 Changed 23 months ago by fdupont

  • Owner changed from fdupont to marcin

A comment which should be updated: // Now remove this address from the hints list. line 2007 so a few line before the patch.
And at the end of the patch IMHO you should remove before // Finally,:

    // For all the leases the client had requested, but we didn't assign, put them with
    // zero lifetimes

I don't know if/where the corresponding address code is checked (perhaps we should remove it and see if something fails) so I can't propose a new unit test. Perhaps QA / system tests will help.

Anyway the code is OK.

comment:6 Changed 23 months ago by marcin

  • Resolution set to fixed
  • Status changed from reviewing to closed

Merged with commit 91bb0855ff7ef86ff72b5a946ae716798d7bebc1

Note: See TracTickets for help on using tickets.