Opened 2 years ago

Closed 2 years ago

#5402 closed defect (fixed)

improper check if ipv6 prefix address already exists in the back-end

Reported by: razvan.becheriu Owned by: marcin
Priority: medium Milestone: Kea1.4
Component: dhcp6 Version: git
Keywords: IA_PD allocation Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: Low
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

in file: src/lib/dhcpsrv/alloc_engine.cc
in function: Lease6Ptr AllocEngine::createLease6
at line: 1400 [ on the 'else' branch of 'if (!ctx.fake_allocation_)' ]

the search for the address:

Lease6Ptr existing = LeaseMgrFactory::instance().getLease6(

Lease::TYPE_NA, addr);

should be:

Lease6Ptr existing = LeaseMgrFactory::instance().getLease6(

ctx.currentIA().type_, addr);

The server functionality is correct because this function is always called after an initial search after the right address, but still, the implementation of the function 'Lease6Ptr AllocEngine::createLease6' is incorrect.

Subtickets

Change History (6)

comment:1 Changed 2 years ago by marcin

  • Milestone changed from Kea-proposed to Kea1.4

Move to Kea 1.4 per Kea team call on November 2nd, 2017

comment:2 Changed 2 years ago by marcin

  • Owner set to marcin
  • Status changed from new to accepted

comment:3 Changed 2 years ago by marcin

  • Owner changed from marcin to UnAssigned
  • Status changed from accepted to reviewing

Ready for review. This doesn't require changelog entry as this is user invisible change.

comment:4 Changed 2 years ago by fdupont

  • Owner changed from UnAssigned to fdupont

comment:5 Changed 2 years ago by fdupont

  • Owner changed from fdupont to marcin

Code OK! I believe it is useless to ask for a unit test...

comment:6 Changed 2 years ago by marcin

  • Resolution set to fixed
  • Status changed from reviewing to closed

Merged with commit 760fc9f1be5256dfb20f6c3f45cc08aee8a39d7f

Note: See TracTickets for help on using tickets.