Opened 2 years ago

Closed 2 years ago

#5399 closed defect (fixed)

-with-tier2 is still required to build subnet_cmds in premium distribution tar ball built with tier2

Reported by: tmark Owned by: UnAssigned
Priority: medium Milestone: Kea1.3-final
Component: build system Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

If one builds a tarball containing the premium content, it is still necessary to use --with-tier2 in the resultant source tree. This seems inconvenient for users. After some brief discussion it was decided that simplest solution is to just change the default of --with-tier2 to be true.

Subtickets

Change History (6)

comment:1 Changed 2 years ago by tmark

  • Owner set to tmark
  • Status changed from new to assigned

comment:2 Changed 2 years ago by tmark

  • Owner changed from tmark to Unassigned
  • Status changed from assigned to reviewing

premium branch trac5399:

Changed the --with-tier2 default to "yes" in premium/configure.ac

ChangeLog?:

1x. [build]     tmark
    Changed --with-tier2 default to "yes" This allows dist tar balls built
     with premium to not require --with-tier2 to build premium content
    (Trac #5399, git TBD)

Ready for review.

Last edited 2 years ago by tmark (previous) (diff)

comment:3 Changed 2 years ago by fdupont

I have a fresh premium test directory ready so I get this one.

comment:4 Changed 2 years ago by fdupont

  • Owner changed from Unassigned to fdupont

comment:5 Changed 2 years ago by fdupont

  • Owner changed from fdupont to UnAssigned

Patch OK if and only if we want to toggle the tier2 default.

comment:6 Changed 2 years ago by tmark

  • Resolution set to fixed
  • Status changed from reviewing to closed

Change merged with git #e3780fb75d8ca7ff8cc8860e738bbf1554b495a9
ChangeLog? entry 18 added.

Ticket is complete.

Note: See TracTickets for help on using tickets.