Opened 2 years ago

Closed 2 years ago

#5391 closed defect (fixed)

revert #3576 minimal length change

Reported by: fdupont Owned by: fdupont
Priority: low Milestone: Kea1.3-final
Component: dhcp Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

Cf PR 57 on GitHub.

Subtickets

Change History (5)

comment:1 Changed 2 years ago by fdupont

  • Owner set to fdupont
  • Status changed from new to accepted

comment:2 Changed 2 years ago by fdupont

  • Owner changed from fdupont to UnAssigned
  • Status changed from accepted to reviewing

Ready for review.

comment:3 Changed 2 years ago by tomek

  • Owner changed from UnAssigned to tomek

comment:4 Changed 2 years ago by tomek

  • Owner changed from tomek to fdupont

Your changes look good. I've build the code and unit-tests on Mac OS 10.12.6.

this change requires a changelog. The original author did not get back to us with any proposals, so here's mine:

13XX.	[func]		earies,fdupont
	The option length checks were relaxed for the V-I Vendor Class
	option.
	(Trac #5391, github #57, git abcd)

This change also requires AUTHORS update. I made the changes. Please pull and review. If you're ok with them, please merge.

comment:5 Changed 2 years ago by fdupont

  • Resolution set to fixed
  • Status changed from reviewing to closed

Merged. Closing.

Note: See TracTickets for help on using tickets.