Opened 2 years ago

Closed 2 years ago

#5389 closed defect (fixed)

Fedora 26 / g++ 7.2.1 warnings

Reported by: fdupont Owned by: fdupont
Priority: medium Milestone: Kea1.4
Component: build system Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

Low priority as they are only warnings...

Subtickets

Attachments (1)

log (277.7 KB) - added by fdupont 2 years ago.
Build log on Fedora 26

Download all attachments as: .zip

Change History (13)

Changed 2 years ago by fdupont

Build log on Fedora 26

comment:1 Changed 2 years ago by fdupont

Same warnings with Ubuntu 17.10... As our obsolete coroutine code gives some, included #4064 into this one.

comment:2 Changed 2 years ago by fdupont

  • Owner set to fdupont
  • Status changed from new to accepted

comment:3 Changed 2 years ago by fdupont

Fixed all the warnings in trac5389 branch. Note the CondVarTest.destroyWhileWait looped on both Ubuntu 17.10 and Fedora 17 beta so either we should revisit the test or simply extend in configure.ac systems which have "undefined pthread behavior". Note I used the googletest source from git and it complains about death test in multi-threaded environment...
Ready for review but in 1.4

comment:4 Changed 2 years ago by fdupont

  • Milestone changed from Kea-proposed to Kea1.4
  • Priority changed from low to medium

comment:5 Changed 2 years ago by fdupont

  • Owner changed from fdupont to UnAssigned
  • Status changed from accepted to reviewing

First attempt available for review.

comment:6 Changed 2 years ago by tomek

  • Component changed from Unclassified to build system
  • Owner changed from UnAssigned to tomek

comment:7 Changed 2 years ago by tomek

  • Owner changed from tomek to fdupont

Changes in module_spec.h|cc. The changes are good, but not sufficient. The module spec is not used in any production code, so it should be removed altogether.

I went and removed that altogether. Please pull and review. If you're ok with those changes, go ahead and merge.

comment:8 Changed 2 years ago by fdupont

I am ok with the changes and I went a bit further by removing config_data.cc, config_data.h and documentation.txt which are about obsolete <module>.spec files.
Please review... BTW I'll install a Fedora 17 (just released) VM and checks Fedora build on it.

comment:9 Changed 2 years ago by fdupont

  • Owner changed from fdupont to tomek

comment:10 Changed 2 years ago by tomek

  • Owner changed from tomek to fdupont

Your changes look good, but the code didn't compile for me. It complained about couple places that still referenced config_spec.h. Not sure how we missed that. Aanyway, fixed the references. Please pull and try to build it in a clean tree. If it builds, I believe it's ready to go.

comment:11 Changed 2 years ago by fdupont

I checked on a fresh Fedora 27 VM: I had to fix a typo in DHCPv6 shared network unit tests (I believed it was fixed but obviously it was not in the branch) and to disable the condvar unit test marked with HAS_UNDEFINED_PTHREAD_BEHAVIOR.
It worked well (even I'd like to retry with databases when I'd get some free time).
Merging.

comment:12 Changed 2 years ago by fdupont

  • Resolution set to fixed
  • Status changed from reviewing to closed

Closing.

Note: See TracTickets for help on using tickets.