Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#5379 closed defect (fixed)

kea-admin fails if no -6 or -4 specified on the command line

Reported by: phoenix Owned by: fdupont
Priority: low Milestone: Kea1.3-final
Component: scripts Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: .5
Total Hours: 1 Internal?: no

Description

If kea-admin is run without specifying whether you want DHCP4/6 leases dumped it will fail by looking for an incorrect procedure name in the DB, the following error message is produced:

ERROR 1305 (42000) at line 1: PROCEDURE kea.lease0DumpData does not exist
ERROR/kea-admin: lease-dump: mysql_execute failed, exit code 1

This is on the recent 1.3.0 beta built on CentOS7

Subtickets

Change History (7)

comment:1 Changed 2 years ago by tomek

  • Component changed from Unclassified to scripts
  • Milestone changed from Kea-proposed to Kea1.3-final
  • Priority changed from medium to low

As discussed on 2017-10-04 call, moving to 1.3-final as low.

comment:2 Changed 2 years ago by fdupont

  • Owner set to fdupont
  • Status changed from new to accepted

comment:3 Changed 2 years ago by fdupont

  • Add Hours to Ticket changed from 0 to .5
  • Owner changed from fdupont to UnAssigned
  • Status changed from accepted to reviewing
  • Total Hours changed from 0 to .5

Added the missing check: done.

comment:4 Changed 2 years ago by tomek

  • Owner changed from UnAssigned to tomek

comment:5 Changed 2 years ago by tomek

  • Owner changed from tomek to fdupont
  • Total Hours changed from .5 to 1

I just reviewed this change. The condition checking was incorrect. It compare against o rather than 0. Fixed that. Please pull.

This is user visible change. It requires a changelog. Here's my proposal:

13XX.	[bug]		fdupont
	The kea-admin script now behaves properly when -4 or -6 is missing
	while using lease-dump command.
	(Trac #5379, git tbd)

comment:6 Changed 2 years ago by fdupont

  • Resolution set to fixed
  • Status changed from reviewing to closed

Done. Closing.

comment:7 Changed 2 years ago by fdupont

  • Summary changed from kea-admin fails if no -6 or -4 specificed on the command line to kea-admin fails if no -6 or -4 specified on the command line
Note: See TracTickets for help on using tickets.