Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#5325 closed defect (fixed)

d2_parser.yy is missing in 1.2.0 release tarball

Reported by: klausfiend Owned by: tmark
Priority: medium Milestone: Kea1.3 beta
Component: build system Version: 1.2.0
Keywords: d2 d2_parser.yy compile compilation build Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

This issue may have been fixed in the meantime, but the source tarball for 1.2.0 doesn't include src/bin/d2/d2_parser.yy, which will cause compilation to fail if '--enable-generate-parser' is included in the options for 'configure'.

Making all in d2
make[4]: Entering directory `/tmp/kea-1.2.0/src/bin/d2'
make  all-recursive
make[5]: Entering directory `/tmp/kea-1.2.0/src/bin/d2'
Making all in .
make[6]: Entering directory `/tmp/kea-1.2.0/src/bin/d2'
make[6]: *** No rule to make target `d2_parser.yy', needed by `d2_parser.cc'.  Stop.
make[6]: Leaving directory `/tmp/kea-1.2.0/src/bin/d2'
make[5]: *** [all-recursive] Error 1
make[5]: Leaving directory `/tmp/kea-1.2.0/src/bin/d2'
make[4]: *** [all] Error 2
make[4]: Leaving directory `/tmp/kea-1.2.0/src/bin/d2'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/tmp/kea-1.2.0/src/bin'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/tmp/kea-1.2.0/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/tmp/kea-1.2.0'
make: *** [all] Error 2

Subtickets

Change History (7)

comment:1 Changed 3 years ago by tmark

  • Owner set to tmark
  • Status changed from new to assigned

This is all we need:

diff --git a/src/bin/d2/Makefile.am b/src/bin/d2/Makefile.am
index 8dc0cfe86..e8eeb8531 100644
--- a/src/bin/d2/Makefile.am
+++ b/src/bin/d2/Makefile.am
@@ -24,6 +24,7 @@ CLEANFILES = *.gcno *.gcda d2_messages.h d2_messages.cc s-messages

man_MANS = kea-dhcp-ddns.8
DISTCLEANFILES = $(man_MANS)
EXTRA_DIST = $(man_MANS) kea-dhcp-ddns.xml dhcp-ddns.spec d2.dox

+EXTRA_DIST += d2_parser.yy

EXTRA_DIST += images/abstract_app_classes.svg images/add_state_model.svg
EXTRA_DIST += images/config_data_classes.svg images/config_from_file_sequence.svg

comment:2 Changed 3 years ago by tomek

  • Milestone changed from Kea-proposed to Kea1.3

Accepting in 1.3 as medium as discussed on 2017-06-29 call. The patch looks good BTW.

comment:3 Changed 3 years ago by tmark

  • Owner changed from tmark to Unassigned
  • Status changed from assigned to reviewing

Ticket is ready for review.

ChangeLog?:

12xx.   [bug]       tmark
    Added a distribution rule to src/bin/d2/Makefile.am so d2_parser.yy
    will now be included in the distribution source tree.
    (Trac #5325, git TBD)

comment:4 Changed 3 years ago by fdupont

  • Owner changed from Unassigned to fdupont

comment:5 Changed 3 years ago by fdupont

  • Owner changed from fdupont to tmark

Patch and ChangeLog proposal OK.

comment:6 Changed 3 years ago by tmark

  • Resolution set to fixed
  • Status changed from reviewing to closed

Had to add header files also found missing from asiolink/Makefile.am:

+libkea_asiolink_la_SOURCES += io_acceptor.h
+libkea_asiolink_la_SOURCES += unix_domain_socket_acceptor.h
+libkea_asiolink_la_SOURCES += unix_domain_socket_endpoint.h

Ticket merged with git #199003d7aa9f8d4a7f8daa73f8259e951bc03217
Added ChangeLog? entry 1270.

Ticket is complete.

comment:7 Changed 3 years ago by vicky

  • Milestone changed from Kea1.3 to Kea1.3 beta

Milestone renamed

Note: See TracTickets for help on using tickets.