Opened 10 years ago

Closed 10 years ago

#52 closed task (fixed)

review: RRset class

Reported by: jinmei Owned by: jinmei
Priority: medium Milestone: 02. Running, functional authoritative-only server
Component: libdns++ Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: Add Hours to Ticket:
Total Hours: Internal?:

Description

The RRset class implementation is ready for review.

It's in the jinmei-dnsrrset branch. The simplest way to get a diff is
to compare the branch against the trunk:
svn diff svn+ssh://bind10.isc.org/svn/bind10/trunk/src/lib/dns/cpp \

svn+ssh://bind10.isc.org/svn/bind10/branches/jinmei-dnsrrset/src/lib/dns/cpp

But basically what should be reviewed are the following three files:

  • rrset.h
  • rrset.cc
  • rrset_unittest.cc

and these have never been reviewed, the reviewer can simply these as
new files.

It contains a relatively detailed document on the API and
implementation design. The HTML version is available at:
http://bind10.isc.org/~jinmei/bind10-rrset/cpp/

Most of the documentation is in rrset.h. So, an easy way to review
the documents is to begin with this page
http://bind10.isc.org/~jinmei/bind10-rrset/cpp/rrset_8h.html
and follow the links there.

One specific note about the current implementation: it's not
integrated RRSIGs in a normal RRset. I'll defer it to the next
development/review phase.

Subtickets

Change History (2)

comment:1 follow-up: Changed 10 years ago by each

This code is substantially similar to the version I used in the each-ds branch, except for additions I needed to make (including setName() and attached RRSIGs). I read it in detail while doing that work, and I have skimmed it again now. With the assumption that the needed features will be added in future development (or adopted from the each-ds branch after review), I think this is fine to commit.

(One problem: The doc has some dead links in it. In http://bind10.isc.org/~jinmei/bind10-rrset/cpp/classisc_1_1dns_1_1_abstract_r_rset.html, for example, every place it says "Referenced by:", if I click the link I get a 404. I assume this due to a doxygen failure rather than a problem in the doxygen formatting, though.)

comment:2 in reply to: ↑ 1 Changed 10 years ago by jinmei

  • Resolution set to fixed
  • Status changed from new to closed

Replying to each:

[snip] I think this is fine to commit.

Thanks.

(One problem: The doc has some dead links in it. In
http://bind10.isc.org/~jinmei/bind10-rrset/cpp/classisc_1_1dns_1_1_abstract_r_rset.html,
for example, every place it says "Referenced by:", if I click the
link I get a 404. I assume this due to a doxygen failure rather
than a problem in the doxygen formatting, though.)

Hmm, you're right. We'll eventually address this issue as a release
engineering matter.

I'm going to close this ticket.

Note: See TracTickets for help on using tickets.