Opened 3 years ago

Closed 3 years ago

#5170 closed defect (fixed)

Fix makefiles for kea-shell (make install)

Reported by: tomek Owned by: fdupont
Priority: medium Milestone: Kea1.2
Component: shell Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: Mozilla Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 1
Total Hours: 1 Internal?: no

Description

There are two outstanding things to do:

  • make install installs kea-shell and all necessary files, but for some reason kea-shell can't load kea_connector2 module.

This is likely because the makefile incorrectly puts everything in /usr/local/bin, while only kea-shell should go there and the .py files should go to some kea specific sub-directory somewhere in python dir.

Subtickets

Change History (7)

comment:1 Changed 3 years ago by tomek

  • Component changed from Unclassified to shell

comment:2 Changed 3 years ago by hschempf

  • Milestone changed from Kea-proposed to Kea1.2

Per 9 Mar team meeting, accept in 1.2

comment:3 Changed 3 years ago by fdupont

For the first point kea-shell does not update the path (cf bind9 python tools) so python can't find kea dependencies. And of course the second point is bound.

comment:4 Changed 3 years ago by fdupont

  • Owner set to fdupont
  • Status changed from new to accepted

comment:5 Changed 3 years ago by fdupont

  • Owner changed from fdupont to UnAssigned
  • Status changed from accepted to reviewing

Ready for review. Note the install path is decided by configure so should not be modified by giving unexpected arguments to make install.

comment:6 Changed 3 years ago by tomek

  • Add Hours to Ticket changed from 0 to 1
  • Owner changed from UnAssigned to fdupont
  • Total Hours changed from 0 to 1

I have reviewed and tested the code. It works on ubuntu 16.04 x64. The code is ready for merge, but you need a changelog for this. If you don't have a better proposal, here's a text you can use:

12XX.	[build]		fdupont
	Installation procedure for kea-shell improved.
	(Trac #5170, git tbd)

comment:7 Changed 3 years ago by fdupont

  • Resolution set to fixed
  • Status changed from reviewing to closed

Merged. Closing.

Note: See TracTickets for help on using tickets.