Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#5124 closed enhancement (complete)

handle required parameters in grammar

Reported by: fdupont Owned by: fdupont
Priority: low Milestone: Kea1.3 beta
Component: remote-management Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets: #5037
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 3
Total Hours: 3 Internal?: no

Description

Cf #5037:

create a ticket to handle missing required parameters in grammar: more efficient, can put in the error message the syntactic context name with { and } positions (in addition to the location of the keyword aka parent).

Subtickets

Change History (17)

comment:1 Changed 3 years ago by fdupont

  • Component changed from Unclassified to remote-management
  • Milestone changed from Kea1.2 to Kea 1.2 - Mozilla Milestone 1

comment:2 Changed 3 years ago by tomek

  • Milestone changed from Kea 1.2 - Mozilla Milestone 1 to Kea1.2
  • Priority changed from medium to low

comment:3 Changed 3 years ago by fdupont

  • Milestone changed from Kea1.2 to Kea 1.2 - Mozilla Milestone 1
  • Owner set to fdupont
  • Priority changed from low to medium
  • Status changed from new to accepted

comment:4 Changed 3 years ago by fdupont

  • Milestone changed from Kea 1.2 - Mozilla Milestone 1 to Kea1.2

comment:5 Changed 3 years ago by fdupont

  • Priority changed from medium to low

comment:6 Changed 3 years ago by fdupont

  • Owner changed from fdupont to UnAssigned
  • Status changed from accepted to reviewing

Found a bug: the OPTION_DEF subparser is missing in dhcpX_lexer.ll so in fact parseOPTION_DEF is parseJSON. Note this subparser handles one option-def map so it is not enough to fix the flex files, and of course it is not critical so please leave this ticket as 1.2 low.

Ready for review.

comment:7 Changed 3 years ago by fdupont

Related to #3590 too. Note it is possible to do more, e.g. check for name or code in option-data.
Still to be reviewed.

comment:8 Changed 3 years ago by fdupont

What to do for D2 aka #5110?
Still to be reviewed.

comment:11 Changed 3 years ago by fdupont

  • Status changed from reviewing to reopened

Oops, comment:9 and comment:10 are in the wrong ticket.

comment:12 Changed 3 years ago by fdupont

Note there are many more things to do so the reviewer should:

1- comment about the way required parameters are handled by the grammar
2- suggest the long list to things to do in the scope of this ticket.

comment:13 Changed 3 years ago by fdupont

  • Status changed from reopened to reviewing

comment:14 Changed 3 years ago by tomek

  • Milestone changed from Kea1.2 to Kea1.2-final

Code freeze for 1.2-beta. Moving all remaining open tickets to 1.2-final.

comment:15 Changed 3 years ago by tomek

  • Milestone changed from Kea1.2-final to Kea1.3

As discussed on 2017-04-13 Kea call, moving all low review tickets that have not started review yet to Kea1.3.

comment:16 Changed 2 years ago by tomek

  • Owner changed from UnAssigned to tomek

comment:17 Changed 2 years ago by tomek

  • Add Hours to Ticket changed from 0 to 2
  • Owner changed from tomek to fdupont
  • Total Hours changed from 0 to 2

I finally got time to review those changes. They look good, but I had couple minor things to improve there. Please pull and review. If you're ok with them, the code is ready to go.

This code was branched off master in January. Lots of things has changed since then. I strongly suggest to rebase the changes first to recent master and rebuild/re-run unit-tests.

This change requires changelog entry. If you don't have any better text, here's my proposal:

12XX.	[func]		fdupont
	The configuration parser now checks for mandatory parameters that
	are missing.
	(Trac #5124, git tbd)

comment:18 Changed 2 years ago by fdupont

  • Add Hours to Ticket changed from 2 to 3
  • Resolution set to complete
  • Status changed from reviewing to closed
  • Total Hours changed from 2 to 3

Reviewed, rebased and merged. Closing.

comment:19 Changed 2 years ago by vicky

  • Milestone changed from Kea1.3 to Kea1.3 beta

Milestone renamed

Note: See TracTickets for help on using tickets.