Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#5116 closed enhancement (worksforme)

Remove obsolete code (legacy stub and DhcpConfigParser)

Reported by: tomek Owned by:
Priority: medium Milestone: Kea 1.2 - Mozilla Milestone 1
Component: configuration Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

This ticket covers 2 things:

  1. Remove boilerplate code one parser migration is complete

This is a minor follow-up for #5019 and #5037. Those tickets call to migrate global parsers, but this task can only be really completed when all other tickets related to parser migration are done. This piece of code is located in src/bin/dhcp{4,6}/json_config_parser.cc.

Until they're done, I have added a very small chunk of code that still does the legacy parsers.

  1. Once #1 is done, the DhcpConfigParser? class can be deleted.

Subtickets

Change History (3)

comment:1 Changed 3 years ago by fdupont

As they are still used in D2 parser IMHO we should move the obsolete code to src/bin/d2 (faster than to wait for #5110).

comment:2 Changed 3 years ago by tomek

  • Resolution set to worksforme
  • Status changed from new to closed

We decided to close this ticket, because:

  1. removal of the legacy stub code in dhcpX/json_config_parser.cc was done in #5019 (merged)
  1. removal of the DhcpConfigParser? was added to #5110.

comment:3 Changed 3 years ago by tomek

  • Milestone changed from Kea-proposed to Kea 1.2 - Mozilla Milestone 1
Note: See TracTickets for help on using tickets.