Opened 3 years ago

Closed 3 years ago

#5085 closed defect (duplicate)

make legacy JSON code more standard compliant

Reported by: fdupont Owned by: UnAssigned
Priority: high Milestone: Kea 1.2 - Mozilla Milestone 1
Component: Unclassified Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

For instance the toJSON can output illegal control characters.
BTW the JSON standard is available at http://www.ecma-international.org/publications/files/ECMA-ST/ECMA-404.pdf

Subtickets

Change History (7)

comment:1 Changed 3 years ago by fdupont

  • Owner set to fdupont
  • Status changed from new to accepted

comment:2 Changed 3 years ago by fdupont

  • Owner changed from fdupont to UnAssigned
  • Status changed from accepted to assigned

Done:

  • toJSON emits unicode escapes when required
  • lexer is able to deal with \u00xy escapes in JSON strings

At the result parser(toJSON(x)) is the identity for any string Element.

Ready for review even obviously some user documentation is missing...

comment:3 Changed 3 years ago by fdupont

  • Owner changed from UnAssigned to fdupont
  • Status changed from assigned to accepted

Taking the ticket the time to address JSON reserved keyword case:

  • better flex messages
  • enforce case in legacy JSON reader

comment:4 Changed 3 years ago by fdupont

  • Owner changed from fdupont to UnAssigned
  • Status changed from accepted to reviewing

Done. Again under review.

comment:5 Changed 3 years ago by fdupont

The {{parser o toJSON == id}}} guarantee is a critical property for the new control API if it does not pass the JSON content without touching it...

comment:6 Changed 3 years ago by tomek

  • Milestone changed from Kea-proposed to Outstanding Tasks

As decided on 2016-12-15 call, we're moving all proposed tickets to outstanding. We simply have too many tickets in 1.2 to accept anything new. Sorry.

comment:7 Changed 3 years ago by fdupont

  • Milestone changed from Outstanding Tasks to Kea 1.2 - Mozilla Milestone 1
  • Resolution set to duplicate
  • Status changed from reviewing to closed

Included into #5017. Closing as a duplicate.

Note: See TracTickets for help on using tickets.