Changes between Initial Version and Version 1 of Ticket #5064, comment 11


Ignore:
Timestamp:
Mar 30, 2017, 6:37:01 PM (3 years ago)
Author:
tmark
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #5064, comment 11

    initial v1  
    1 I just reviewed 5080 and it does include changes that DO install the legal log library into <prefix>/lib/hooks/ so you should probably just close this ticket as resolved by 5080.
     1In reviewing 5080 it appears that you corrected the library installation in master?
     2
     3commit b0c01c83336db25d257845acd0235cc69024ac5e
     4Author: Francis Dupont <fdupont@isc.org>
     5Date:   Mon Feb 13 13:38:17 2017 +0100
     6
     7    Installed legal log library
     8
     9
     10diff --git a/src/hooks/dhcp/legal_log/Makefile.am b/src/hooks/dhcp/legal_log/Makefile.am
     11index 8d7883e..d2431cf 100644
     12--- a/src/hooks/dhcp/legal_log/Makefile.am
     13+++ b/src/hooks/dhcp/legal_log/Makefile.am
     14@@ -54,7 +54,9 @@ if USE_CLANGPP
     15 liblegl_la_CXXFLAGS += -Wno-unused-parameter
     16 endif
     17
     18-noinst_LTLIBRARIES += libdhcp_legal_log.la
     19+# install the shared object into $(libdir)/hooks
     20+lib_hooksdir = $(libdir)/hooks
     21+lib_hooks_LTLIBRARIES = libdhcp_legal_log.la
     22
     23 libdhcp_legal_log_la_SOURCES  =
     24 libdhcp_legal_log_la_LDFLAGS  = $(AM_LDFLAGS)
     25
     26So it would appear that this ticket has been resolved without trac5064.