Opened 3 years ago

Closed 3 years ago

#5062 closed defect (fixed)

TEST_F(RenewTest, requestPrefixInRenew) may be time sensitive

Reported by: tmark Owned by: fdupont
Priority: low Milestone: Kea1.2
Component: dhcp6 Version: git
Keywords: unit tests Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 2 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

dhcp6 server unit test TEST_F(RenewTest?, requestPrefixInRenew) appears to fail sporardically due to a time sensitivity:

Value of: leases_client_na_renewed[0].cltt_ - leases_client_na[0].cltt_
  Actual: 1001
Expected: 1000

Stacktrace

renew_unittest.cc:264
Value of: leases_client_na_renewed[0].cltt_ - leases_client_na[0].cltt_
  Actual: 1001
Expected: 1000

The comparison that fails should probably be EXPECT_GE rather tnat EXPECT_EQ.

Subtickets

Change History (8)

comment:1 Changed 3 years ago by fdupont

or an interval, e.g. _GE 1000 and _LT 1002

comment:2 Changed 3 years ago by hschempf

  • Milestone changed from Kea-proposed to Kea1.2

Per Dec 1 Kea team meeting, accept 1.2

comment:3 Changed 3 years ago by tomek

  • Priority changed from medium to low

comment:4 Changed 3 years ago by fdupont

  • Owner set to fdupont
  • Status changed from new to accepted

comment:5 Changed 3 years ago by fdupont

  • Owner changed from fdupont to UnAssigned
  • Status changed from accepted to reviewing

Done. Ready for review.

comment:6 Changed 3 years ago by wlodekwencel

  • Owner changed from UnAssigned to wlodekwencel

comment:7 Changed 3 years ago by wlodekwencel

  • Owner changed from wlodekwencel to fdupont

Changed macro name to STRICT_TEST_TIMING

Good for merge

comment:8 Changed 3 years ago by fdupont

  • Resolution set to fixed
  • Status changed from reviewing to closed

Merged. Closing.

Note: See TracTickets for help on using tickets.