Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#5060 closed enhancement (complete)

Specialize eval flex/bison scanner/parser

Reported by: fdupont Owned by: fdupont
Priority: medium Milestone: Kea 1.2 - Mozilla Milestone 1
Component: classification Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0.5
Total Hours: 0.5 Internal?: no

Description

The idea is to replace the "yy" prefix by "eval" so multiple flex/bison scanners/parsers can be used.
Cf. private e-mail exchange with Tomek.
Note even it is not needed it makes things cleaner.

Subtickets

Change History (6)

comment:1 Changed 3 years ago by fdupont

  • Owner set to fdupont
  • Status changed from new to accepted

comment:2 Changed 3 years ago by fdupont

  • Owner changed from fdupont to UnAssigned
  • Status changed from accepted to reviewing

Done. Ready for review.

comment:3 Changed 3 years ago by tomek

  • Component changed from Unclassified to classification
  • Milestone changed from Kea-proposed to Kea1.2
  • Owner changed from UnAssigned to tomek

I have reviewed those changes. The code didn't build on mac 10.11.5, but the problem would likely manifest itself everywhere. There was one line in lexer.ll that still called yy_scan_bytes rather than eval_scan_bytes. I pushed a fix for this. Please review.

With this minor fix, the change looks good. Please merge.

comment:4 Changed 3 years ago by tomek

  • Add Hours to Ticket changed from 0 to 0.5
  • Owner changed from tomek to fdupont
  • Total Hours changed from 0 to 0.5

Thanks a lot for tweaking this. I do understand basics of flex and bison, but doing more advanced things is often still a mystery for me.

comment:5 Changed 3 years ago by fdupont

  • Resolution set to complete
  • Status changed from reviewing to closed

I worked a lot with bison (e.g. making bison parse engines in Caml), less with flex...
Merged. Closing.

comment:6 Changed 3 years ago by tomek

  • Milestone changed from Kea1.2 to Kea 1.2 - Mozilla Milestone 1
Note: See TracTickets for help on using tickets.