Opened 3 years ago

Closed 3 years ago

#5055 closed defect (fixed)

Some headers from the lib/dhcp/ are not installed

Reported by: marcin Owned by: marcin
Priority: medium Milestone: Kea1.2
Component: Unclassified Version: git
Keywords: Cc: sidsharma8485@…
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: Medium
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 4 Add Hours to Ticket: 8
Total Hours: 8 Internal?: no

Description

The src/lib/dhcp/Makefile.am lists the header files to be installed, i.e. libkea_dhcp_include_HEADERS.
This list lacks some of the header files that should also be installed and that may be required for the hooks development outside Kea tree.

Subtickets

Change History (8)

comment:1 Changed 3 years ago by electronixid

  • Cc sidsharma8485@… added

comment:2 Changed 3 years ago by marcin

  • Milestone changed from Kea-proposed to Kea1.2

Moving to 1.2 per Kea team meeting on 10/20/2016.

comment:3 Changed 3 years ago by marcin

  • Owner set to marcin
  • Status changed from new to accepted

comment:4 Changed 3 years ago by marcin

  • Add Hours to Ticket changed from 0 to 8
  • Estimated Difficulty changed from 0 to 4
  • Owner changed from marcin to UnAssigned
  • Status changed from accepted to reviewing
  • Total Hours changed from 0 to 8

I went over all the Kea libraries and selected those headers which I thought would be useful for hooks development. Note that it was also required to install all headers they depend on. So, there is quite large number of newly installed headers.

Proposed ChangeLog entry:

11XX.	[build]		marcin
	Install Kea headers to be used for building external libraries.
	Before this change some required headers were not installed.
	(Trac #5055, git abcd)

comment:5 Changed 3 years ago by fdupont

  • Owner changed from UnAssigned to fdupont

comment:6 Changed 3 years ago by fdupont

  • Owner changed from fdupont to marcin

I suggest to replace $(includedir)/$(PACKAGE_NAME) by (simpler so better) $(pkgincludedir).
BTW IMHO all headers should be installed, i.e., to not install a header should be an exception.
Ready for merge.

comment:7 Changed 3 years ago by electronixid

+1 to fdupont's comment

comment:8 Changed 3 years ago by marcin

  • Resolution set to fixed
  • Status changed from reviewing to closed

Merged with commit a46087b7b7face4a1318658bbdcbf7602c1bb729

Note: See TracTickets for help on using tickets.